Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add fasttext jpn language model #1

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

wvanamstel
Copy link

Added fasttext Japanese language model in its own directory. Renamed the original w2v src directory. To be done: change Dockerfile to reflect these changes.

@vampolo
Copy link
Owner

vampolo commented Feb 21, 2018

Hey @wvanamstel, thanks for the contribuition.
I think we should make a stronger folder change here. What I mean is to have 2 folders in the root: word2vec and fasttext. Each of those have their entrypoint.sh and src folder with the relevant changes.
Do you think you can make those changes? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants