Added functions to ctx for RedisModule_GetClient* #180
+86
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
dmitrypol
commented
Feb 24, 2025
•
dmitrypol
commented
- added functions to Context to get_client_id, name, username, info and certificate in separate client.rs
- added example and tests
dmitrypol
commented
Feb 25, 2025
src/context/mod.rs
Outdated
| ValkeyString::from_redis_module_string(self.ctx, client_cert) | ||
| } | ||
|
|
||
| pub fn get_client_info(&self) -> ValkeyValue { |
There was a problem hiding this comment.
@KarthikSubbarao - I decided to just return u64 here, we can revisit it later redis/redis#13828 (comment)
dmitrypol
commented
Feb 25, 2025
src/context/mod.rs
Outdated
| @@ -829,6 +830,36 @@ impl Context { | |||
| .map_err(|_e| ValkeyError::Str("User does not have permissions on key")) | |||
| } | |||
|
|
|||
| pub fn get_client_id(&self) -> u64 { | |||
There was a problem hiding this comment.
@KarthikSubbarao - also since mod.rs is a very large file I moved these to a new filesrc/context/client.rs and did impl Context for these 5 functions.
* updated version to 0.1.3 Signed-off-by: Dmitry Polyakovsky <[email protected]> * Add support for generating bindings on ValkeyModule APIs (valkey-io#172) * Add support for generating bindings on ValkeyModule APIs Signed-off-by: Karthik Subbarao <[email protected]> * Update header files to match latest OSS core engine header files Signed-off-by: Karthik Subbarao <[email protected]> --------- Signed-off-by: Karthik Subbarao <[email protected]> Signed-off-by: Dmitry Polyakovsky <[email protected]> * minor cleanup tests and data_type2.rs updated dependencies Signed-off-by: Dmitry Polyakovsky <[email protected]> --------- Signed-off-by: Dmitry Polyakovsky <[email protected]> Signed-off-by: Karthik Subbarao <[email protected]> Co-authored-by: Dmitry Polyakovsky <[email protected]> Co-authored-by: KarthikSubbarao <[email protected]> Signed-off-by: Dmitry Polyakovsky <[email protected]>
minor tweaks Signed-off-by: Dmitry Polyakovsky <[email protected]>
Signed-off-by: Dmitry Polyakovsky <[email protected]>
added example and tests Signed-off-by: Dmitry Polyakovsky <[email protected]>
Signed-off-by: Dmitry Polyakovsky <[email protected]>
…io#178) Signed-off-by: VanessaTang <[email protected]> Signed-off-by: Dmitry Polyakovsky <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.