-
Notifications
You must be signed in to change notification settings - Fork 724
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pass null-terminated node ID for VM_RegisterClusterMessageReceiver
and add test coverage
#1708
Pass null-terminated node ID for VM_RegisterClusterMessageReceiver
and add test coverage
#1708
Conversation
Signed-off-by: Nikhil Manglore <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## unstable #1708 +/- ##
============================================
+ Coverage 71.06% 71.14% +0.08%
============================================
Files 121 123 +2
Lines 65254 65534 +280
============================================
+ Hits 46371 46627 +256
- Misses 18883 18907 +24
|
Looking into the CI Failure |
…nctionality Signed-off-by: Nikhil Manglore <[email protected]>
Signed-off-by: Nikhil Manglore <[email protected]>
Signed-off-by: Nikhil Manglore <[email protected]>
Signed-off-by: Nikhil Manglore <[email protected]>
Signed-off-by: Nikhil Manglore <[email protected]>
Signed-off-by: Nikhil Manglore <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly LGTM.
Signed-off-by: Nikhil Manglore <[email protected]>
Signed-off-by: Nikhil Manglore <[email protected]>
VM_RegisterClusterMessageReceiver
and add test coverage
Signed-off-by: Nikhil Manglore <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, just some nits, then let's merge it.
Signed-off-by: Nikhil Manglore <[email protected]>
Signed-off-by: Nikhil Manglore <[email protected]>
Pass
sender_id
asNULL
terminated string as part ofValkeyModuleClusterMessageReceiver
for ease of usage by the module(s).Implement test coverage described in Add test coverage for module callback registration for cluster message via
VM_RegisterClusterMessageReceiver
#1656 and ensures that nodes in the cluster module properly acknowledge a "DING" message by sending a "DONG" response.Closes #1656.