tests: Use fork instead of forkserver #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugant
requested review from
mkmkme,
ahmedsobeh,
smeso and
bogdanp05
as code owners
bugant
force-pushed
the
use-multiprocessing-fork-instead-of-forkserver
branch
from
8514c61 to
5fe7e54
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #174 +/- ##
==========================================
- Coverage 76.26% 76.26% -0.01%
==========================================
Files 130 130
Lines 33964 33970 +6
==========================================
+ Hits 25903 25906 +3
- Misses 8061 8064 +3 ☔ View full report in Codecov by Sentry. |
bugant
force-pushed
the
use-multiprocessing-fork-instead-of-forkserver
branch
from
5fe7e54 to
ab1c205
Compare
Make sure test can be successfully run on pyton 3.14. According to https://docs.python.org/dev/whatsnew/3.14.html#multiprocessing The default start method (see Contexts and start methods) changed from fork to forkserver on platforms other than macOS & Windows where it was already spawn. If you require the threading incompatible fork start method you must explicitly request it using a context from multiprocessing.get_context() (preferred) or change the default via multiprocessing.set_start_method(). See also https://bugzilla.redhat.com/show_bug.cgi?id=2326934 for reference on the reported bug for the Fedora package. Signed-off-by: Matteo Centenaro <[email protected]>
bugant
force-pushed
the
use-multiprocessing-fork-instead-of-forkserver
branch
from
ab1c205 to
76de3d1
Compare
mkmkme
approved these changes
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure test can be successfully run on pyton 3.14.
According to
https://docs.python.org/dev/whatsnew/3.14.html#multiprocessing
The default start method (see Contexts and start methods) changed from fork to forkserver on platforms other than macOS & Windows where it was already spawn. If you require the threading incompatible fork start method you must explicitly request it using a context from multiprocessing.get_context() (preferred) or change the default via multiprocessing.set_start_method().
See also https://bugzilla.redhat.com/show_bug.cgi?id=2326934 for reference on the reported bug for the Fedora package.
Pull Request check-list
Description of change