Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add instruction to run c# and current .net target #890

Merged
merged 6 commits into from
Feb 5, 2024

Conversation

Sa1Gur
Copy link
Collaborator

@Sa1Gur Sa1Gur commented Feb 1, 2024

Adding instuction and runnable launch.json for csharp. Also updating frameworks list to match current version.
In the process corrected version selector (to detect correct library base on OS)

@Sa1Gur Sa1Gur requested a review from a team as a code owner February 1, 2024 19:36
Copy link
Contributor

@shachlanAmazon shachlanAmazon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for your contribution! I added just a few small corrections.

Please be aware that the C# wrapper isn't currently under active development. If you'd like to contribute to it, you're more than welcome to do that, but there isn't any other active work on it in right now.

.vscode/launch.json Outdated Show resolved Hide resolved
<Content Include="$(MSBuildThisFileDirectory)target/release/libglide_rs.so">
<CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
<Link>%(FileName)%(Extension)</Link>
<ItemGroup>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

have you tested this on windows / mac?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it on Mac. On Windows I used it in other projects, but couldn't build rust lib now, so didn't fully test

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did I manage to address all comments, or are you waiting on some of my changes? Please, point out if I need to change something else

csharp/README.md Outdated Show resolved Hide resolved
csharp/README.md Outdated Show resolved Hide resolved
csharp/DEVELOPER.md Outdated Show resolved Hide resolved
csharp/DEVELOPER.md Outdated Show resolved Hide resolved
csharp/DEVELOPER.md Outdated Show resolved Hide resolved
csharp/DEVELOPER.md Outdated Show resolved Hide resolved
csharp/DEVELOPER.md Show resolved Hide resolved
.vscode/launch.json Outdated Show resolved Hide resolved
@shachlanAmazon shachlanAmazon merged commit d7c0ee2 into valkey-io:main Feb 5, 2024
3 checks passed
@shachlanAmazon
Copy link
Contributor

Thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants