-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add instruction to run c# and current .net target #890
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much for your contribution! I added just a few small corrections.
Please be aware that the C# wrapper isn't currently under active development. If you'd like to contribute to it, you're more than welcome to do that, but there isn't any other active work on it in right now.
<Content Include="$(MSBuildThisFileDirectory)target/release/libglide_rs.so"> | ||
<CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory> | ||
<Link>%(FileName)%(Extension)</Link> | ||
<ItemGroup> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
have you tested this on windows / mac?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested it on Mac. On Windows I used it in other projects, but couldn't build rust lib now, so didn't fully test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did I manage to address all comments, or are you waiting on some of my changes? Please, point out if I need to change something else
Thanks for the contribution! |
Adding instuction and runnable launch.json for csharp. Also updating frameworks list to match current version.
In the process corrected version selector (to detect correct library base on OS)