Add CD workflow for publishing to PyPi #661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barshaul
force-pushed
the
pypi_release
branch
30 times, most recently
from
83c3909 to
524701f
Compare
barshaul
force-pushed
the
pypi_release
branch
from
e744eca to
e5d9b5b
Compare
barshaul
force-pushed
the
pypi_release
branch
2 times, most recently
from
bb264eb to
4e56ebf
Compare
barshaul
force-pushed
the
pypi_release
branch
from
4e56ebf to
fa5044f
Compare
| @@ -38,7 +38,7 @@ runs: | |||
| - name: Install Python software dependencies | |||
| shell: bash | |||
| run: | | |||
| python3 -m ensurepip --upgrade | |||
| python3 -m ensurepip --upgrade || true | |||
There was a problem hiding this comment.
On some ubuntu platforms this command isn't allowed and we install pip in another way so we can skip it if it fails
| if: matrix.build.PYPI_PUBLISH == true && !contains(matrix.build.RUNNER, 'self-hosted') | ||
| uses: actions/setup-python@v4 | ||
| with: | ||
| python-version: "3.10" |
There was a problem hiding this comment.
shouldn't we use 3.6, to ensure that we support it?
There was a problem hiding this comment.
we're building for all python versions (8-12), but this stage is only required to have some local installs. anyway python3.8 setup isn't supported on some of the platforms, thus I chose this version
| @@ -1,6 +1,6 @@ | |||
| [package] | |||
| name = "pybushka" | |||
| version = "0.1.0" | |||
| version = "255.255.255" | |||
There was a problem hiding this comment.
It's on purpose, I need to have some version that will be override by the workflow with the version tag. Cargo doesn't allow to put there some other place holder such as ${package_version) or x.x.x ...
shachlanAmazon
approved these changes
Dec 14, 2023
barshaul
force-pushed
the
pypi_release
branch
from
fa5044f to
eadce24
Compare
barshaul
force-pushed
the
pypi_release
branch
7 times, most recently
from
9947926 to
ec6c9f2
Compare
barshaul
force-pushed
the
pypi_release
branch
from
ec6c9f2 to
ba94261
Compare
barshaul
changed the title
barshaul
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebased over #681 and #682