Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go: Update README #3168

Merged
merged 6 commits into from
Feb 14, 2025
Merged

Go: Update README #3168

merged 6 commits into from
Feb 14, 2025

Conversation

edlng
Copy link
Contributor

@edlng edlng commented Feb 13, 2025

Updated the README to reflect latest changes in Go.

Issue link

This Pull Request is linked to issue (URL): #3150

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one issue.
  • Commit message has a detailed description of what changed and why.
  • Tests are added or updated.
  • CHANGELOG.md and documentation files are updated.
  • Destination branch is correct - main or release
  • Create merge commit if merging release branch into main, squash otherwise.

Signed-off-by: Edward Liang <[email protected]>
Signed-off-by: Edward Liang <[email protected]>
@edlng edlng requested a review from a team as a code owner February 13, 2025 22:40
1. Open your terminal in your project directory.
2. Execute the command below:
```bash
$ go get github.com/valkey-io/valkey-glide/go
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this tested?

Copy link
Contributor Author

@edlng edlng Feb 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes it's been tested. I had to add an addition go mod tidy afterwards to fix some issues. But I found out that this won't work on Intel macs. However, it works on Ubuntu

@Yury-Fridlyand Yury-Fridlyand added go golang wrapper docs Documentation labels Feb 13, 2025
go/README.md Outdated Show resolved Hide resolved
Signed-off-by: Edward Liang <[email protected]>
@yipin-chen yipin-chen changed the base branch from main to release-1.3 February 13, 2025 23:48
@yipin-chen yipin-chen changed the base branch from release-1.3 to main February 13, 2025 23:48
@jbrinkman
Copy link
Collaborator

How does a markdown file cause our integration tests to fail?

Copy link
Collaborator

@jamesx-improving jamesx-improving left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line 7:

and it supports all Valkey commands

better add extra disclamer here, like Public preview have limited command implementation etc

@tjzhang-BQ
Copy link
Collaborator

How does a markdown file cause our integration tests to fail?

could be something flakey

@yipin-chen yipin-chen merged commit 0333c37 into valkey-io:main Feb 14, 2025
18 checks passed
@yipin-chen yipin-chen deleted the go/update-readme branch February 14, 2025 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation go golang wrapper
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants