-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Go: Update README
#3168
Go: Update README
#3168
Conversation
Signed-off-by: Edward Liang <[email protected]>
Signed-off-by: Edward Liang <[email protected]>
1. Open your terminal in your project directory. | ||
2. Execute the command below: | ||
```bash | ||
$ go get github.com/valkey-io/valkey-glide/go |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this tested?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes it's been tested. I had to add an addition go mod tidy
afterwards to fix some issues. But I found out that this won't work on Intel macs. However, it works on Ubuntu
Signed-off-by: Edward Liang <[email protected]>
How does a markdown file cause our integration tests to fail? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line 7:
and it supports all Valkey commands
better add extra disclamer here, like Public preview have limited command implementation
etc
could be something flakey |
Signed-off-by: Edward Liang <[email protected]>
Updated the
README
to reflect latest changes in Go.Issue link
This Pull Request is linked to issue (URL): #3150
Checklist
Before submitting the PR make sure the following are checked: