Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport to 1.3] example markdown #3167

Merged
merged 2 commits into from
Feb 14, 2025

Conversation

jbrinkman
Copy link
Collaborator

@jbrinkman jbrinkman commented Feb 13, 2025

Issue link

This Pull Request is linked to issue (#3150)

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one issue.
  • Commit message has a detailed description of what changed and why.
  • Tests are added or updated.
  • CHANGELOG.md and documentation files are updated.
  • Destination branch is correct - main or release
  • Create merge commit if merging release branch into main, squash otherwise.

@jbrinkman jbrinkman requested a review from a team as a code owner February 13, 2025 22:12
@jbrinkman jbrinkman closed this Feb 13, 2025
@jbrinkman jbrinkman deleted the go/jbrinkman-backport-example-markdown branch February 13, 2025 22:13
@jbrinkman jbrinkman restored the go/jbrinkman-backport-example-markdown branch February 13, 2025 22:15
@jbrinkman jbrinkman reopened this Feb 13, 2025
@jbrinkman jbrinkman changed the base branch from main to release-1.3 February 13, 2025 22:16
* remove unneeded example file
* Add examples.md

---------

Signed-off-by: Joseph Brinkman <[email protected]>
@jbrinkman jbrinkman force-pushed the go/jbrinkman-backport-example-markdown branch from fcf5c67 to 54ab0bc Compare February 13, 2025 22:21
@jbrinkman jbrinkman added this to the 1.3 milestone Feb 13, 2025
@jbrinkman jbrinkman added the go golang wrapper label Feb 13, 2025
Copy link
Collaborator

@yipin-chen yipin-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like James' suggestion.

@yipin-chen yipin-chen merged commit 53712c4 into release-1.3 Feb 14, 2025
17 of 18 checks passed
@yipin-chen yipin-chen deleted the go/jbrinkman-backport-example-markdown branch February 14, 2025 00:06
@yipin-chen yipin-chen mentioned this pull request Feb 18, 2025
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go golang wrapper
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants