Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Go: Add Go CD approval #3146

Merged
merged 1 commit into from
Feb 12, 2025
Merged

Go: Add Go CD approval #3146

merged 1 commit into from
Feb 12, 2025

Conversation

jamesx-improving
Copy link
Collaborator

@jamesx-improving jamesx-improving commented Feb 12, 2025 •
edited by yipin-chen
Loading

Issue link

This Pull Request is linked to issue (URL): #3051

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one issue.
  • Commit message has a detailed description of what changed and why.
  • Tests are added or updated.
  • CHANGELOG.md and documentation files are updated.
  • Destination branch is correct - main or release
  • Create merge commit if merging release branch into main, squash otherwise.

NOTE: All workflow_dispatch workflows (i.e.: manually triggered workflows) only takes the version from main, hence we have to merge to main (instead of release-1.3)

@jamesx-improving
Go: Add Go CD approval
4786b68 
Signed-off-by: James Xin <[email protected]>
@jamesx-improving jamesx-improving requested a review from a team as a code owner February 12, 2025 17:47
@yipin-chen yipin-chen mentioned this pull request Feb 12, 2025
Closed
14 tasks
@jamesx-improving jamesx-improving merged commit 957b183 into main Feb 12, 2025
10 checks passed
@jamesx-improving jamesx-improving deleted the go/jamesx-add-go-cd-approval branch February 12, 2025 21:12
@Yury-Fridlyand Yury-Fridlyand added go golang wrapper CI/CD CI/CD related labels Feb 14, 2025
Yury-Fridlyand pushed a commit that referenced this pull request Feb 14, 2025
@jamesx-improving @Yury-Fridlyand
Go: Add Go CD approval (#3146)
0c26324 
Signed-off-by: James Xin <[email protected]>
@Yury-Fridlyand Yury-Fridlyand mentioned this pull request Feb 14, 2025
Merged
yipin-chen pushed a commit that referenced this pull request Feb 14, 2025
@Yury-Fridlyand @jamesx-improving
[Backport 1.3] Go: Add Go CD approval (#3146) (#3171)
295371d 
Go: Add Go CD approval (#3146)

Signed-off-by: James Xin <[email protected]>
Co-authored-by: James Xin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbrinkman jbrinkman jbrinkman approved these changes

@yipin-chen yipin-chen yipin-chen approved these changes

Assignees
No one assigned
Labels
CI/CD CI/CD related go golang wrapper
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jamesx-improving @jbrinkman @yipin-chen @Yury-Fridlyand