Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auto assign external actors issues #3111

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Conversation

avifenesh
Copy link
Member

@avifenesh avifenesh commented Feb 9, 2025

Issue link

This Pull Request is linked to issue #2732
This pull request introduces a new GitHub Actions workflow for issue triage. The workflow is designed to automatically label issues created by non-contributors, helping to streamline the issue management process.

Key changes include:

  • New Workflow Addition:
    • .github/workflows/issue-triage.yml: Added a new workflow named "Issue Triage" that triggers on newly opened issues. This workflow checks if the issue creator is a contributor and labels the issue accordingly if they are not.

The change can be tested just after it will be merged, hence currently is untested

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one issue.
  • Commit message has a detailed description of what changed and why.
  • Tests are added or updated.
  • CHANGELOG.md and documentation files are updated.
  • Destination branch is correct - main or release
  • Create merge commit if merging release branch into main, squash otherwise.

@avifenesh avifenesh requested a review from a team as a code owner February 9, 2025 22:37
@avifenesh avifenesh requested a review from ikolomi February 9, 2025 22:38
@avifenesh avifenesh added CI/CD CI/CD related tools Dev tools and utils - not CI/CD or OPS labels Feb 9, 2025
@avifenesh avifenesh linked an issue Feb 9, 2025 that may be closed by this pull request
3 tasks
@avifenesh avifenesh self-assigned this Feb 9, 2025
Copy link
Collaborator

@ikolomi ikolomi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont think making a distinction on what constitutes "User" issue basing on commits existence and org affiliation is an incorrect approach.

If i understand correctly, the intent is to mark issues that are potentially blocks the users as opposed to issues that are discovered by developers.

IMHO, a more straightforward and convenient way would be one of the following options:

  1. Have a template for opening a "Production" or "User pain" issue - i think that "User pain" template nails the purpose exactly.

  2. Note in the issue template that for blocking issue the opener should add "User pain" label

@avifenesh
Copy link
Member Author

I dont think making a distinction on what constitutes "User" issue basing on commits existence and org affiliation is an incorrect approach.

If i understand correctly, the intent is to mark issues that are potentially blocks the users as opposed to issues that are discovered by developers.

IMHO, a more straightforward and convenient way would be one of the following options:

  1. Have a template for opening a "Production" or "User pain" issue - i think that "User pain" template nails the purpose exactly.
  2. Note in the issue template that for blocking issue the opener should add "User pain" label

@ikolomi
I didn't put user pain as the label, since, as you say correctly, I can't distinguish.

It's a "User issue".
We can think in your direction - but in this case, we should remove the "bug" and "features" templates.
And add, "bug - user pain" and "development - bug", "feature request" and "feature - development".
Users open bug issues, feature issues, and just non labeled issues, the intent is to have a way to filter internal vs external to be able to fast response.
Agree that external bug/blocker is the highest priority.
We can mix approaches - using the labeling + adding a template for "bug in production/blocker", so we can really get all the abilities.

Note that the next step, while ready, is to auto-assign on caller to those so he gets a notification directly.
In the current volume of traffic, I think we can afford to get a notification on external interaction.

@avifenesh avifenesh requested a review from ikolomi February 11, 2025 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/CD CI/CD related tools Dev tools and utils - not CI/CD or OPS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task] issue management automation.
2 participants