Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Go: Fix command options classes. #3104

Merged
merged 7 commits into from
Feb 12, 2025
Merged

Go: Fix command options classes. #3104

merged 7 commits into from
Feb 12, 2025

Conversation

Yury-Fridlyand
Copy link
Collaborator

@Yury-Fridlyand Yury-Fridlyand commented Feb 7, 2025 •
edited
Loading

  1. All .toArgs() which return []string replaced with .toArgs() which return ([]string, error)
  2. All options moved to options
  3. Rework and align options for cluster commands
  4. Move constants to constants.go
  5. Added more const strigs to constants
  6. Rename options factory methods (NewSortOptionsBuilder -> NewSortOptions)
  7. Corresponding doc and test updates

@Yury-Fridlyand
Fix options.
5aa84f7 
Signed-off-by: Yury-Fridlyand <[email protected]>
@Yury-Fridlyand
examples
8c39446 
Signed-off-by: Yury-Fridlyand <[email protected]>
@Yury-Fridlyand Yury-Fridlyand added the go golang wrapper label Feb 7, 2025
@Yury-Fridlyand Yury-Fridlyand changed the title Fix options. Go: Fix command options classes. Feb 7, 2025
@Yury-Fridlyand
move
e40b4b8 
Signed-off-by: Yury-Fridlyand <[email protected]>
@Yury-Fridlyand
constants
78c0707 
Signed-off-by: Yury-Fridlyand <[email protected]>
@Yury-Fridlyand
Merge remote-tracking branch 'upstream/release-1.3' into go/fix-optio…
5e613f1 
…ns-toargs

Signed-off-by: Yury-Fridlyand <[email protected]>
@Yury-Fridlyand Yury-Fridlyand marked this pull request as ready for review February 8, 2025 04:04
@Yury-Fridlyand Yury-Fridlyand requested a review from a team as a code owner February 8, 2025 04:04
@Yury-Fridlyand
Rename constructors.
fffd586 
Signed-off-by: Yury-Fridlyand <[email protected]>
jbrinkman
jbrinkman approved these changes Feb 10, 2025
View reviewed changes
Copy link
Collaborator

@jbrinkman jbrinkman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

yipin-chen
yipin-chen approved these changes Feb 12, 2025
View reviewed changes
Copy link
Collaborator

@yipin-chen yipin-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Yury-Fridlyand Yury-Fridlyand merged commit ca615bc into release-1.3 Feb 12, 2025
18 checks passed
@Yury-Fridlyand Yury-Fridlyand deleted the go/fix-options-toargs branch February 12, 2025 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbrinkman jbrinkman jbrinkman approved these changes

@yipin-chen yipin-chen yipin-chen approved these changes

Assignees
No one assigned
Labels
go golang wrapper
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Yury-Fridlyand @jbrinkman @yipin-chen