Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Go: Fix flaky test. #3102

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Go: Fix flaky test. #3102

wants to merge 2 commits into from

Conversation

Yury-Fridlyand
Copy link
Collaborator

Sometimes TestObjectIdleTime fails:

=== NAME  TestGlideTestSuite/TestObjectIdleTime
    shared_commands_test.go:6339: 
        	Error Trace:	/home/runner/work/valkey-glide/valkey-glide/go/integTest/shared_commands_test.go:6582
        	            				/home/runner/work/valkey-glide/valkey-glide/go/integTest/glide_test_suite_test.go:269
        	Error:      	"4" is not greater than or equal to "5"
        	Test:       	TestGlideTestSuite/TestObjectIdleTime

@Yury-Fridlyand
Fix flaky test.
7346164 
Signed-off-by: Yury-Fridlyand <[email protected]>
@Yury-Fridlyand Yury-Fridlyand added go golang wrapper testing Everything about testing labels Feb 7, 2025
@Yury-Fridlyand Yury-Fridlyand requested a review from a team as a code owner February 7, 2025 20:21
@Yury-Fridlyand
lint
7ebf481 
Signed-off-by: Yury-Fridlyand <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yipin-chen yipin-chen yipin-chen approved these changes

Assignees
No one assigned
Labels
go golang wrapper testing Everything about testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Yury-Fridlyand @yipin-chen