Go: Fix XRange and XRevRange return data type
#3052
Conversation
Signed-off-by: Edward Liang <[email protected]>
Signed-off-by: Edward Liang <[email protected]>
| sort.Slice(xRangeResponseArray, func(i, j int) bool { | ||
| return xRangeResponseArray[i].StreamId < xRangeResponseArray[j].StreamId | ||
| }) |
There was a problem hiding this comment.
I think since we get a map from the CommandResponse, the order of the entries are not guaranteed. Followed by that, the iteration I do to add these map entries to an array also would not guarantee the order is maintained. So I decided to add a sort to ensure the returned array is in order
There was a problem hiding this comment.
Not sure that we need it, but I don't mind
There was a problem hiding this comment.
I think adding sort would be helpful in the XRevRange results but let me know your thoughts @jbrinkman
There was a problem hiding this comment.
This sounds like there is a problem with the Glide Core implementation. I think using sort here is warranted to guarantee that the sorting is maintained.
| sort.Slice(xRangeResponseArray, func(i, j int) bool { | ||
| return xRangeResponseArray[i].StreamId > xRangeResponseArray[j].StreamId | ||
| }) |
There was a problem hiding this comment.
Same reasoning as above but this time we return the order in reverse
Signed-off-by: Edward Liang <[email protected]>
| sort.Slice(xRangeResponseArray, func(i, j int) bool { | ||
| return xRangeResponseArray[i].StreamId < xRangeResponseArray[j].StreamId | ||
| }) |
There was a problem hiding this comment.
This sounds like there is a problem with the Glide Core implementation. I think using sort here is warranted to guarantee that the sorting is maintained.
| sort.Slice(xRangeResponseArray, func(i, j int) bool { | ||
| return xRangeResponseArray[i].StreamId > xRangeResponseArray[j].StreamId | ||
| }) |
Issue link
This Pull Request is linked to issue (URL):
Checklist
Before submitting the PR make sure the following are checked: