Core: Add AzAffinityAllNodes Read Strategy #2986
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Muhammad-awawdi-amazon
added
Feature
adarovadya
reviewed
Jan 28, 2025
glide-core/redis-rs/redis/src/cluster_async/connections_container.rs
Outdated
Show resolved
Hide resolved
adarovadya
reviewed
Jan 28, 2025
adarovadya
reviewed
Jan 28, 2025
| @@ -302,6 +302,103 @@ mod cluster_async { | |||
| ); | |||
| } | |||
|
|
|||
| #[tokio::test] | |||
| async fn test_routing_by_slot_to_replica_with_az_affinity_all_nodes_strategy_to_half_replicas() | |||
There was a problem hiding this comment.
Run the exiting test twice, once for AZAffinity and once for the new strategy
adarovadya
reviewed
Jan 28, 2025
| @@ -392,6 +489,209 @@ mod cluster_async { | |||
| ); | |||
| } | |||
|
|
|||
| #[tokio::test] | |||
| async fn test_routing_by_slot_to_replica_with_az_affinity_all_nodes_strategy_to_all_replicas() { | |||
There was a problem hiding this comment.
same here. use the existing test
adarovadya
reviewed
Jan 28, 2025
| let cluster = | ||
| TestClusterContext::new((replica_num * primaries_num) + primaries_num, replica_num); | ||
| let client_az = "us-east-1a".to_string(); | ||
| let other_az = "us-east-1b".to_string(); |
There was a problem hiding this comment.
you dont need it. it will be empty string anyway, and different from client az
adarovadya
reviewed
Jan 28, 2025
| .route_command( | ||
| &cmd, | ||
| RoutingInfo::SingleNode(SingleNodeRoutingInfo::SpecificNode(Route::new( | ||
| 10923, // This should target the third primary |
There was a problem hiding this comment.
Why did you not use the same slot as previous tests that mapped to the foo key?
adarovadya
reviewed
Jan 28, 2025
| @@ -288,6 +288,64 @@ where | |||
| } | |||
| } | |||
|
|
|||
| /// Returns the node's connection in the same availability zone as `client_az`, | |||
| /// checking replicas first, then primary, and falling back to any available node. | |||
| pub(crate) fn round_robin_read_from_replica_with_az_awareness_all_nodes( | |||
There was a problem hiding this comment.
It would be better to create a helping function and to use the same logic for both functions with flag, this one and the already exits round_robin_read_from_replica_with_az_awareness function. Both functions logic except of step 2, is duplicate
Signed-off-by: Muhammad Awawdi <[email protected]>
Muhammad-awawdi-amazon
force-pushed
the
primary-az-read
branch
from
a36c302 to
5183314
Compare
…asAndPrimary Signed-off-by: Muhammad Awawdi <[email protected]>
Signed-off-by: Muhammad Awawdi <[email protected]>
Signed-off-by: Muhammad Awawdi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue link
This Pull Request is linked to issue (URL): #2792
Checklist
Before submitting the PR make sure the following are checked: