Go: ZRANDMEMBER.
#2983
Open
Go: ZRANDMEMBER.
#2983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yury-Fridlyand <[email protected]>
7 tasks
Signed-off-by: Yury-Fridlyand <[email protected]>
Signed-off-by: Yury-Fridlyand <[email protected]>
Signed-off-by: Yury-Fridlyand <[email protected]>
yipin-chen
approved these changes
Jan 21, 2025
tjzhang-BQ
reviewed
Jan 23, 2025
| @@ -7,6 +7,7 @@ const ( | |||
| MatchKeyword string = "MATCH" // Valkey API keyword used to indicate the match filter. | |||
| NoValue string = "NOVALUE" // Valkey API keyword for the no value option for hcsan command. | |||
| WithScore string = "WITHSCORE" // Valkey API keyword for the with score option for zrank and zrevrank commands. | |||
There was a problem hiding this comment.
is the WITHSCORE one even an option? We tested that with some commands passing WITHSCORE in the place where the doc asks for WITHSCORES would work, but is any command explicitly asking for WITHSCORE? if not we should probably remove
cc @prateek-kumar-improving
There was a problem hiding this comment.
Probably we could keep it there with lowercase (aka private)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue link
This Pull Request is linked to issue (URL): #2973
Checklist
Before submitting the PR make sure the following are checked: