Go: Implement Custom Command with route(Generic Cluster cmd), Ping with Route #2979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Niharika Bhavaraju <[email protected]>
There was a problem hiding this comment.
We discussed API naming with the team and agreed to follow approach we started with node client. If command have optional argument, we wrap them with options struct and provide 2 APIs: cmd and cmdWithOptions.
Currently PING has 2 optional arguments and 4 APIs (4 permutations):
PingPingWithMessagePingWithRoutePingWithMessageAndRoute
Imagine PING gets a new optional argument later in future. Current solution is not scalable. So the proposal is to refactor it now into the following:
PingPingWithOptions
And follow that approach for all commands.
If you have any concerns, please, share. I'm happy to discuss that there or in a GLIDE contribution meeting.
Signed-off-by: Niharika Bhavaraju <[email protected]>
Signed-off-by: Niharika Bhavaraju <[email protected]>
Signed-off-by: Niharika Bhavaraju <[email protected]>
Signed-off-by: Niharika Bhavaraju <[email protected]>
Signed-off-by: Niharika Bhavaraju <[email protected]>
Signed-off-by: Niharika Bhavaraju <[email protected]>
4 tasks
Signed-off-by: Niharika Bhavaraju <[email protected]>
Signed-off-by: Niharika Bhavaraju <[email protected]>
…alkey-glide into pingcommand-niharika
Signed-off-by: Niharika Bhavaraju <[email protected]>
Signed-off-by: Niharika Bhavaraju <[email protected]>
…alkey-glide into pingcommand-niharika
Signed-off-by: Niharika Bhavaraju <[email protected]>
Signed-off-by: Niharika Bhavaraju <[email protected]>
Signed-off-by: Niharika Bhavaraju <[email protected]>
prateek-kumar-improving
approved these changes
Jan 29, 2025
Signed-off-by: Yury-Fridlyand <[email protected]>
Yury-Fridlyand
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Go: Implement Custom Command with route(Generic Cluster cmd), Ping with Route