Core: Extract proto from socket-layer feature.

[Yury-Fridlyand]

No changes for clients or user API.

But we can build non-UDS clients on windows now:

C:\projects\glide\go>cargo build
   Compiling glide-core v0.1.0 (C:\projects\glide\glide-core)
   Compiling glide-rs v0.1.0 (C:\projects\glide\go)
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 5.78s

[Yury-Fridlyand]

It is not mandatory, but it puts generated files to a place where they could be found

[Yury-Fridlyand]

c_long is i64, but on windows is i32 🤦

[avifenesh]

In what case we don't need the proto?

[Yury-Fridlyand]

socket-layer includes proto. This PR adds option to activate proto feature without activating socket-layer.
For example, go client uses protobuf, but doesn't use UDS.

[avifenesh]

socket-layer includes proto. This PR adds option to activate proto feature without activating socket-layer. For example, go client uses protobuf, but doesn't use UDS.

I completely understand. But now when you are changing, which is great, I'm wondering why Protobuf feature at all? Do we have a scenario when we don't use proto?

[Yury-Fridlyand]

Do we have a scenario when we don't use proto?

Not yet.

[avifenesh]

Do we have a scenario when we don't use proto?

Not yet.

So i think we should remove it. If and when we will, we can add it.

[Yury-Fridlyand]

I just recalled that .Net client don't use it. But maybe it would.

[avifenesh]

I just recalled that .Net client don't use it. But maybe it would.

@Sa1Gur any input on C# usage (or not) of protobuf for communication?

[Sa1Gur]

I just recalled that .Net client don't use it. But maybe it would.

@Sa1Gur any input on C# usage (or not) of protobuf for communication?

It is not using protobuf and frankly I would be surprised if using of protobuf would bring any benefit (but to be sure we need to measure of course). .NET have quite efficient support of native calls. And I doubt anything could bit that. But again - needs to be tested

[avifenesh]

I just recalled that .Net client don't use it. But maybe it would.

@Sa1Gur any input on C# usage (or not) of protobuf for communication?

It is not using protobuf and frankly I would be surprised if using of protobuf would bring any benefit (but to be sure we need to measure of course). .NET have quite efficient support of native calls. And I doubt anything could bit that. But again - needs to be tested

@Yury-Fridlyand so its seems that it is needed.
@Sa1Gur Out of the scope of this PR, but I would love to understand how this support is so efficient so we don't need a communication protocol at all.
Consider it an optional subject for contributors meeting.