Java: Add command Zrangestore. (Sorted Set Group) (#202)
#1276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SanHalacogluImproving
force-pushed
the
java/integ_SanH_Zrangestore
branch
from
b6284a6 to
3c3391c
Compare
Yury-Fridlyand
requested review from
jonathanl-bq,
barshaul,
Yury-Fridlyand,
acarbonetto and
shohamazon
java/client/src/main/java/glide/api/commands/SortedSetBaseCommands.java
Outdated
Show resolved
Hide resolved
java/client/src/main/java/glide/api/commands/SortedSetBaseCommands.java
Outdated
Show resolved
Hide resolved
java/client/src/main/java/glide/api/commands/SortedSetBaseCommands.java
Outdated
Show resolved
Hide resolved
|
Please rebase on main and update IT in |
java/client/src/main/java/glide/api/models/BaseTransaction.java
Outdated
Show resolved
Hide resolved
java/client/src/main/java/glide/api/models/BaseTransaction.java
Outdated
Show resolved
Hide resolved
SanHalacogluImproving
force-pushed
the
java/integ_SanH_Zrangestore
branch
from
d1eb85b to
f7f0759
Compare
Yury-Fridlyand
approved these changes
Apr 16, 2024
| @Test | ||
| public void zrangestore_by_lex_returns_success() { | ||
| // setup | ||
| String source = "testSourceKey"; |
There was a problem hiding this comment.
With a fresh look I see it is an overkill for testing one command implemented by 2 functions.
Consider to create a set of UT for rangeoptions and reduce commands' UT. (in another PR)
The same applicable for zaddoptions and all others.
aaron-congo
reviewed
Apr 16, 2024
aaron-congo
approved these changes
Apr 16, 2024
SanHalacogluImproving
force-pushed
the
java/integ_SanH_Zrangestore
branch
from
6d10f03 to
c7331f5
Compare
acarbonetto
approved these changes
Apr 16, 2024
Elen-Ghulam
approved these changes
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.