-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds more tests #27
Adds more tests #27
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
If I were nit picking I'd say add the missing trailing newlines and use [[ over [ consistently.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Being a fork that removed everything except the specific tests for Valkey there are some files that could be deleted like config.sh
, even more important is a deprecated Docker flag as --link
that limits my ability to run the tests under Podman as well as some ShellCheck errors that would be convenient to fix.
I have opened a PR to address these issues against this branch here.
I'm not sure why you're copying all the tests, especially without changes; the bashbrew GitHub action will run the tests in You can also explicitly set You might also want to switch from |
The reason I am doing this is, in future we might be moving away and we might want to modify the tests and add new ones. WDYT @tianon, does it makes sense? |
Signed-off-by: Roshan Khatri <[email protected]>
Signed-off-by: Roshan Khatri <[email protected]>
Signed-off-by: diana esteves <[email protected]> Signed-off-by: Roshan Khatri <[email protected]>
Signed-off-by: Roshan Khatri <[email protected]>
Signed-off-by: Roshan Khatri <[email protected]>
Signed-off-by: Roshan Khatri <[email protected]>
e1fb507
to
a427d8b
Compare
Signed-off-by: Ivan Gabaldon <[email protected]> Signed-off-by: Roshan Khatri <[email protected]>
a427d8b
to
aad0fe9
Compare
This PR forks all the redis tests that were running on the docker-library/official-images.
I have added these as the external tests while we're using the bashbrew scripts to build, run, test and push it.