-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: set 7 and latest as 7.2 aliases #16
Conversation
Signed-off-by: Saurav Sharma <[email protected]>
@roshkhatri @hpatro Can you guys take a look at this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will set the latest
tag for the Valkey 7.2.5 image.
On another thought and discussion with @hpatro we should probably just set the 7.2 as |
@roshkhatri With semantic versioning, if you specific 7, you would expect the latest version of 7.x.y according to semantic versioning. Which in this case would be 7.2, so I think we should release a 7. |
Does this get called out in SemVer? From what I read here https://semver.org/#backusnaur-form-grammar-for-valid-semver-versions is it to have major.minor.patch to be a valid semver. |
That's not exactly what I meant, I was saying that if you put in 7, I would expect it to be most recent version of 7 (ordered by semantic versioning. Where 7.2.5 is later than 7.0.99) |
@roshkhatri @hpatro I think your suggestion will cause more confusion than actually helping. Lots of containers, even Redis, use |
Did take a look at some other popular docker containers Bitnami Redis (https://hub.docker.com/r/bitnami/redis/tags) uses major.minor and major.minor.patch version releases and doesn't have a major version only tag. However, NodeJS/Postgres/OpenSearch/Alpine, all support a major version only tag. With these many data point(s) I guess it's a standard practice. |
Create aliases for 7.2