-
-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more search options #22
base: master
Are you sure you want to change the base?
Conversation
What does |
it filters the results by format, such as jpg, png, gif, etc. |
I think the |
Could you also add it to the readme? |
Yes, fileType is clearer indeed. I've changed it and updated the readme as well. |
yeah.. please return all the data from search. Now it is on us which data we want to use. |
|
||
Type: `string` | ||
|
||
The format of images to search. E.g. `jpg` or `GIF`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can it be just gif
instead? Or does it have to be uppercased?
@@ -7,9 +7,9 @@ class Client { | |||
constructor(id, apiKey) { | |||
this.endpoint = 'https://www.googleapis.com'; | |||
this.apiKey = apiKey; | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Extra newline.
this.id = id; | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing newline.
Included another option to search by format