Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more search options #22

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

Theeeus
Copy link

@Theeeus Theeeus commented Jan 21, 2017

Included another option to search by format

@vadimdemedes
Copy link
Owner

What does fileType option customize?

@Theeeus
Copy link
Author

Theeeus commented Jan 23, 2017

it filters the results by format, such as jpg, png, gif, etc.

@vadimdemedes
Copy link
Owner

I think the fileType would be more clear than format. When I saw format, I initially thought xml, json, etc.

@vadimdemedes
Copy link
Owner

Could you also add it to the readme?

@Theeeus
Copy link
Author

Theeeus commented Jan 23, 2017

Yes, fileType is clearer indeed. I've changed it and updated the readme as well.

@abhi11210646
Copy link

yeah.. please return all the data from search. Now it is on us which data we want to use.


Type: `string`

The format of images to search. E.g. `jpg` or `GIF`.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can it be just gif instead? Or does it have to be uppercased?

@@ -7,9 +7,9 @@ class Client {
constructor(id, apiKey) {
this.endpoint = 'https://www.googleapis.com';
this.apiKey = apiKey;

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra newline.

this.id = id;
}

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing newline.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants