Add utils module
#53
Merged
Add utils module
#53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oskarth
approved these changes
Sep 27, 2022
richard-ramos
requested changes
Sep 27, 2022
utils/Cargo.toml
Outdated
| edition = "2021" | ||
|
|
||
| [dependencies] | ||
| ark-ff = { version = "0.3.0", default-features = false, features = ["parallel", "asm"] } |
There was a problem hiding this comment.
Suggested change
| ark-ff = { version = "0.3.0", default-features = false, features = ["parallel", "asm"] } | |
| ark-ff = { version = "0.3.0", default-features = false, features = ["asm"] } |
utils/Cargo.toml
Outdated
| ark-bn254 = { version = "0.3.0" } | ||
| num-traits = "0.2.11" | ||
| hex-literal = "0.3.4" | ||
| tiny-keccak = { version = "2.0.2", features = ["keccak"] } |
There was a problem hiding this comment.
Suggested change
| tiny-keccak = { version = "2.0.2", features = ["keccak"] } | |
| tiny-keccak = { version = "2.0.2", features = ["keccak"] } | |
| [features] | |
| default = ["parallel"] | |
| parallel = ["ark-ff/parallel"] |
rln/Cargo.toml
Outdated
| @@ -30,13 +30,10 @@ num-traits = "0.2.11" | |||
| once_cell = "1.14.0" | |||
| rand = "0.8" | |||
| tiny-keccak = { version = "2.0.2", features = ["keccak"] } | |||
| utils = { path = "../utils/" } | |||
There was a problem hiding this comment.
Suggested change
| utils = { path = "../utils/" } | |
| utils = { path = "../utils/", default-features = false } |
There was a problem hiding this comment.
Also, once this file is rebased, utils should be added to the parallel feature
parallel = ["ark-ec/parallel", "ark-ff/parallel", "ark-std/parallel", "ark-groth16/parallel", "utils/parallel"]
s1fr0
force-pushed
the
add-utils-module
branch
from
e476732 to
e19b4ea
Compare
|
@richard-ramos I've implemented the changes you requested. Could you please have a last check? Thanks! |
This was
linked to
issues
Sep 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #52 by moving the
rlnPoseidon and Merkle Tree crates toutils.Note that this branch is based on
add-lfsr-poseidonwhich implements #52 and will be rebased on master whenadd-lfsr-poseidonis merged.