Skip to content

Commit

Permalink
chore: move mm:refc config and remove skipParentCfg (#1190)
Browse files Browse the repository at this point in the history
- Moving the `mm:refc` configuration to the main `config.nims` file
makes it be used in tests and tasks that build examples.
- It's not clear why `skipParentCfg`was being used and it doesn't seem
to be necessary.
  • Loading branch information
diegomrsantos authored Sep 10, 2024
1 parent 9669965 commit 21a4441
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 6 deletions.
3 changes: 3 additions & 0 deletions config.nims
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,9 @@ switch("warning", "LockLevel:off")
switch("warningAsError", "UseBase:on")
--styleCheck:
error
--mm:
refc
# reconsider when there's a version-2-2 branch worth testing with as we might switch to orc

# Avoid some rare stack corruption while using exceptions with a SEH-enabled
# toolchain: https://github.com/status-im/nimbus-eth2/issues/3121
Expand Down
4 changes: 2 additions & 2 deletions libp2p.nimble
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,8 @@ let verbose = getEnv("V", "") notin ["", "0"]

let cfg =
" --styleCheck:usages --styleCheck:error" &
(if verbose: "" else: " --verbosity:0 --hints:off") &
" --skipParentCfg --skipUserCfg -f" & " --threads:on --opt:speed"
(if verbose: "" else: " --verbosity:0 --hints:off") & " --skipUserCfg -f" &
" --threads:on --opt:speed"

import hashes, strutils

Expand Down
4 changes: 0 additions & 4 deletions tests/config.nims
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,6 @@ import strutils, os
libp2p_mplex_metrics
--d:
unittestPrintTime
--skipParentCfg
--mm:
refc
# reconsider when there's a version-2-2 branch worth testing with as we might switch to orc

# Only add chronicles param if the
# user didn't specify any
Expand Down

0 comments on commit 21a4441

Please sign in to comment.