ref: Move plugin to separate submodule, add plugin api test project

[MarcinVaadin]

Moved plugin to separate module, added plugin api test project

[czp13]

Very nice one! The test project works for me! And this is super helpful to test changes without shooting up a lot of other stuffs.

> Task :plugin-api-test-client:test
PluginApiTests > testWrite() PASSED
PluginApiTests > testWriteBinary() PASSED
PluginApiTests > testDelete() PASSED

The only thing I need to do to change this variable to my case:

    private static final String PROJECT_BASE_PATH = "/Users/pczuczor/Projects/intellij-plugin";

Could we mention somewhere that developers need to fine tune this variable to their environment?
(And not sure if it worth the hassle to extract it to app property, but mentioning in readme would be helpful or somewhere)

Other option to make it relative path maybe.

[MarcinVaadin]

Other option to make it relative path maybe.

Suggestions applied, please retest

[czp13]

Ah, I played with it, my Intellij is quite weird.

Not all tests are passing (write always pass, delete usually failed, writeBinary sometimes fails)

But definitely the path check for the plugin file is dynamic, relate 👍 So works better!
Maybe there is some flakiness in my environment, I will investigate a bit, what is going on.

[MarcinVaadin]

Test updated, please remember to always run test project while running current plugin snapshot (Run Plugin). Otherwise it will be testing version that is installed by default in IntelliJ.

[czp13]

Test updated, please remember to always run test project while running current plugin snapshot (Run Plugin). Otherwise it will be testing version that is installed by default in IntelliJ.

First I did not run the plugin, and it was testing nothing, as the client was null and it was exiting silently.
We might want to assertTrue that client is not null and put some error, log message?

Then I started the plugin, and then I began to get some flakiness said (so deletion was not always working).

[github-actions]

Artifact build on last commit: distributions.zip.
For MacOS users: there is a zip inside this zip and Finder unzips them both at once. Use unzip distributions.zip from Terminal or check solution for Archive Manager.

[github-actions]

Plugin com.vaadin.intellij-plugin:1.0-SNAPSHOT against IC-233.11799.241

Compatible. 1 usage of deprecated API. 53 usages of experimental API

[github-actions]

Plugin com.vaadin.intellij-plugin:1.0-SNAPSHOT against IU-233.11799.241

Compatible. 1 usage of deprecated API. 65 usages of experimental API

[github-actions]

Plugin com.vaadin.intellij-plugin:1.0-SNAPSHOT against IU-251.14649.49

Compatible. 2 usages of deprecated API. 37 usages of experimental API

[github-actions]

Plugin com.vaadin.intellij-plugin:1.0-SNAPSHOT against IC-251.14649.49

Compatible. 2 usages of deprecated API. 25 usages of experimental API

[czp13]

Let's not block this further and merge it! Thank you for the work.

[czp13]

Stating it works, the only small thing is that I encounter an IDEA window error everytime I run the tests:

But maybe just my envorinment:

java.lang.Throwable: Invalid file: file:///Users/pczuczor/Projects/intellij-plugin/plugin-api-test-client/src/test/resources/test.txt (invalid)
	at com.intellij.openapi.diagnostic.Logger.error(Logger.java:376)