Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adding Delete file command #315

Merged
merged 4 commits into from
Feb 13, 2025
Merged

Conversation

czp13
Copy link
Contributor

@czp13 czp13 commented Feb 12, 2025

Description

Adding delete file handler, needed for copilot (ext) project to be able to handle cases when we want to undo cases where we added a new file.

Type of change

  • Bugfix
  • Feature

Checklist

  • I have read the contribution guide: https://vaadin.com/docs/latest/guide/contributing/overview/
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.

Additional for Feature type of change

  • Enhancement / new feature was discussed in a corresponding GitHub issue and Acceptance Criteria were created.

@czp13
Copy link
Contributor Author

czp13 commented Feb 12, 2025

I am not sure if we want to add tests for covering these handlers, I saw only one test so far called:

  • CopilotUndoManagerTest.

czp13 and others added 3 commits February 12, 2025 17:04
- compilation error (merge mistakes),
- rework the DeleteFileHandler to be more consistent with other handlers,
… automated maybe for automatic running for commits :)
Copy link
Member

@MarcinVaadin MarcinVaadin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine, tested with undo. Redo after undo needs to be investigated in separate PR.

@MarcinVaadin MarcinVaadin enabled auto-merge (squash) February 13, 2025 08:08
Copy link

Artifact build on last commit: distributions.zip.
For MacOS users: there is a zip inside this zip and Finder unzips them both at once. Use unzip distributions.zip from Terminal or check solution for Archive Manager.

@MarcinVaadin MarcinVaadin merged commit 1cb31e7 into main Feb 13, 2025
9 checks passed
@MarcinVaadin MarcinVaadin deleted the feature/delete-file-command branch February 13, 2025 08:17
Copy link

Plugin com.vaadin.intellij-plugin:1.0-SNAPSHOT against IC-233.11799.241

Compatible. 1 usage of deprecated API. 53 usages of experimental API

Copy link

Plugin com.vaadin.intellij-plugin:1.0-SNAPSHOT against IC-251.14649.49

Compatible. 2 usages of deprecated API. 25 usages of experimental API

Copy link

Plugin com.vaadin.intellij-plugin:1.0-SNAPSHOT against IU-251.14649.49

Compatible. 2 usages of deprecated API. 37 usages of experimental API

Copy link

Plugin com.vaadin.intellij-plugin:1.0-SNAPSHOT against IU-233.11799.241

Compatible. 1 usage of deprecated API. 65 usages of experimental API

@MarcinVaadin
Copy link
Member

I am not sure if we want to add tests for covering these handlers

It's pretty complicated to add tests for Java based projects. Needs some investigation about how to setup project with JVM and proper dependencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants