-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Adding Delete file command #315
Conversation
I am not sure if we want to add tests for covering these handlers, I saw only one test so far called:
|
… automated maybe for automatic running for commits :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works fine, tested with undo. Redo after undo needs to be investigated in separate PR.
Artifact build on last commit: distributions.zip. |
Plugin com.vaadin.intellij-plugin:1.0-SNAPSHOT against IC-233.11799.241Compatible. 1 usage of deprecated API. 53 usages of experimental API |
Plugin com.vaadin.intellij-plugin:1.0-SNAPSHOT against IC-251.14649.49Compatible. 2 usages of deprecated API. 25 usages of experimental API |
Plugin com.vaadin.intellij-plugin:1.0-SNAPSHOT against IU-251.14649.49Compatible. 2 usages of deprecated API. 37 usages of experimental API |
Plugin com.vaadin.intellij-plugin:1.0-SNAPSHOT against IU-233.11799.241Compatible. 1 usage of deprecated API. 65 usages of experimental API |
It's pretty complicated to add tests for Java based projects. Needs some investigation about how to setup project with JVM and proper dependencies. |
Description
Adding delete file handler, needed for copilot (ext) project to be able to handle cases when we want to undo cases where we added a new file.
Type of change
Checklist
Additional for
Feature
type of change