-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Only run one save action compile at a time #311
Conversation
Maybe we should use platform API for concurrency? https://github.com/JetBrains/intellij-community/blob/a555f2f6c8cc4ed54462362b737687859cca318b/platform/util/src/com/intellij/util/concurrency/Semaphore.java and others |
I am not sure how that |
Ok, I understand the change, one thing - if compileAndReload somehow fails and do not publish finished event we will have lock never released? |
Yes, then no further compiles will take place and that is why it uses an executor service so that if this would happen, then IntelliJ won't freeze completely but only the started thread. At some point it will run out of threads though. Maybe we should have a timeout |
Now it hopefully waits up to 30s, gives up and proceeds |
Artifact build on last commit: distributions.zip. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, let's go with that one
No description provided.