Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: support bun 1.2 lock file #20900

Merged
merged 1 commit into from
Jan 24, 2025
Merged

fix: support bun 1.2 lock file #20900

merged 1 commit into from
Jan 24, 2025

Conversation

tepi
Copy link
Contributor

@tepi tepi commented Jan 23, 2025

Fixes #20896

@tepi tepi mentioned this pull request Jan 23, 2025
Closed
@tepi tepi requested a review from mshabarov January 23, 2025 14:59
@github-actions GitHub Actions
Copy link

Test Results

1 165 files  ± 0  1 165 suites  ±0   1h 31m 39s ⏱️ - 8m 12s
7 625 tests ± 0  7 569 ✅ + 1  56 💤 ±0  0 ❌ ±0 
7 889 runs   - 95  7 826 ✅  - 92  63 💤  - 2  0 ❌ ±0 

Results for commit 674f71a. ± Comparison against base commit 69a1986.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
1428 New issues
9 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

mcollovati
mcollovati approved these changes Jan 24, 2025
View reviewed changes
Copy link
Collaborator

@mcollovati mcollovati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally with bun 1.1.45 and 1.2.0, and it works correctly with both.

@tepi tepi merged commit 711a36c into main Jan 24, 2025
26 checks passed
@tepi tepi deleted the fix/bun-1.2-lockfile branch January 24, 2025 07:08
vaadin-bot pushed a commit that referenced this pull request Jan 24, 2025
@tepi @vaadin-bot
fix: support bun 1.2 lock file (#20900)
51f0bee
vaadin-bot pushed a commit that referenced this pull request Jan 24, 2025
@tepi @vaadin-bot
fix: support bun 1.2 lock file (#20900)
f98fd4c
vaadin-bot added a commit that referenced this pull request Jan 24, 2025
@vaadin-bot @tepi
fix: support bun 1.2 lock file (#20900) (#20903)
fc8df06 
Co-authored-by: Teppo Kurki <[email protected]>
vaadin-bot added a commit that referenced this pull request Jan 24, 2025
@vaadin-bot @tepi
fix: support bun 1.2 lock file (#20900) (#20902)
f62d831 
Co-authored-by: Teppo Kurki <[email protected]>
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 24.7.0.alpha6 and is also targeting the upcoming stable 24.7.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollovati mcollovati mcollovati approved these changes

@mshabarov mshabarov Awaiting requested review from mshabarov

Assignees
No one assigned
Labels
cherry-picked-24.5 cherry-picked-24.6 prerelease version for Vaadin 24.7.0 Released with Vaadin 24.7.0.alpha6 target/24.5 target/24.6 +0.0.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support Bun 1.2
3 participants
@tepi @vaadin-bot @mcollovati