chore: Use custom react transform in development mode #20804
Merged
+101
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Artur-
force-pushed
the
react-transform
branch
from
380c5d8 to
7473483
Compare
Needed for Copilot to get source information as React 19 drops _debugSource from fiber nodes
Artur-
force-pushed
the
react-transform
branch
from
7473483 to
700a029
Compare
mshabarov
reviewed
Jan 8, 2025
flow-server/src/main/java/com/vaadin/flow/server/frontend/TaskGenerateReactFiles.java
Show resolved
Hide resolved
| @@ -0,0 +1,3 @@ | |||
| import { createElement as reactCreateElement } from "react"; | |||
|
|
|||
| export const createElement = reactCreateElement; | |||
There was a problem hiding this comment.
Who uses this export? Is this re-export really needed?
flow-server/src/main/resources/com/vaadin/flow/server/frontend/jsx-dev-transform/jsx-runtime.ts
Show resolved
Hide resolved
flow-server/src/main/java/com/vaadin/flow/server/frontend/TaskGenerateReactFiles.java
Show resolved
Hide resolved
|
mshabarov
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed for Copilot to get source information as React 19 drops _debugSource from fiber nodes