fix: browser parsing #20657
Merged
fix: browser parsing #20657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added new opera userAgent string. Better logging for failures. Better matching for version string. Fixed android mistaken check. Part of #20610
caalador
force-pushed
the
issues/20610-browser-parsing
branch
from
2da102f to
951709d
Compare
Add isIPad Add testing userAgent strings from json file.
|
mshabarov
approved these changes
Dec 12, 2024
vaadin-bot
pushed a commit
that referenced
this pull request
Dec 12, 2024
* fix: browser parsing Added new opera userAgent string. Better logging for failures. Better matching for version string. Fixed android mistaken check. Part of #20610 * Add ios firefox parsing Add isIPad Add testing userAgent strings from json file.
mcollovati
pushed a commit
that referenced
this pull request
Dec 12, 2024
* fix: browser parsing Added new opera userAgent string. Better logging for failures. Better matching for version string. Fixed android mistaken check. Part of #20610 * Add ios firefox parsing Add isIPad Add testing userAgent strings from json file. Co-authored-by: caalador <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added new opera userAgent string.
Better logging for failures.
Better matching for version string.
Fixed android mistaken check.
Part of #20610