Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump eclipse platform dependencies to the latest versions #19940

Merged
merged 3 commits into from
Sep 18, 2024

Conversation

mcollovati
Copy link
Collaborator

No description provided.

Copy link

github-actions bot commented Sep 12, 2024

Test Results

1 135 files  ± 0  1 135 suites  ±0   1h 25m 53s ⏱️ -55s
7 393 tests ± 0  7 343 ✅ ± 0  50 💤 ±0  0 ❌ ±0 
7 728 runs   - 28  7 668 ✅  - 28  60 💤 ±0  0 ❌ ±0 

Results for commit faf7c7a. ± Comparison against base commit 4895513.

♻️ This comment has been updated with latest results.

@mcollovati mcollovati marked this pull request as ready for review September 12, 2024 08:19
@mcollovati mcollovati requested a review from ZheSun88 September 12, 2024 08:20
@@ -132,7 +132,7 @@
<dependency>
<groupId>org.eclipse.platform</groupId>
<artifactId>org.eclipse.core.resources</artifactId>
<version>3.17.0</version>
<version>3.21.0</version>
<scope>test</scope>
<exclusions>
<exclusion>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this <exclusion> still needed?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue mentioned in the commit that introduced the exclusion has been fixed.
I think we can remove the exclusion

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

flow-client/pom.xml Outdated Show resolved Hide resolved
Copy link

@mshabarov mshabarov requested a review from ZheSun88 September 16, 2024 11:16
@ZheSun88 ZheSun88 merged commit c615be5 into main Sep 18, 2024
25 of 26 checks passed
@ZheSun88 ZheSun88 deleted the chore/bump-eclipse-platform-deps branch September 18, 2024 09:01
vaadin-bot pushed a commit that referenced this pull request Sep 18, 2024
)

* chore: bump eclipse platform dependencies to the latest versions

* cleanup pom

* cleanup pom
@vaadin-bot
Copy link
Collaborator

Hi @mcollovati and @ZheSun88, when i performed cherry-pick to this commit to 24.3, i have encountered the following issue. Can you take a look and pick it manually?
Error Message:
Error: Command failed: git cherry-pick c615be5
error: could not apply c615be5... chore: bump eclipse platform dependencies to the latest versions (#19940)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

mcollovati added a commit that referenced this pull request Sep 18, 2024
)

* chore: bump eclipse platform dependencies to the latest versions

* cleanup pom

* cleanup pom
vaadin-bot added a commit that referenced this pull request Sep 18, 2024
) (#19975)

* chore: bump eclipse platform dependencies to the latest versions

* cleanup pom

* cleanup pom

Co-authored-by: Marco Collovati <[email protected]>
ZheSun88 pushed a commit that referenced this pull request Sep 18, 2024
) (#19976)

* chore: bump eclipse platform dependencies to the latest versions

* cleanup pom

* cleanup pom
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants