Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: preserve navigated.current value #19539

Merged
merged 5 commits into from
Jun 10, 2024
Merged

fix: preserve navigated.current value #19539

merged 5 commits into from
Jun 10, 2024

Conversation

tltv
Copy link
Member

@tltv tltv commented Jun 7, 2024 •
edited
Loading

Fixes: #19525

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 7, 2024 •
edited
Loading

Test Results

1 124 files  ± 0  1 124 suites  ±0   1h 22m 23s ⏱️ -48s
7 249 tests + 2  7 200 ✅ + 2  49 💤 ±0  0 ❌ ±0 
7 587 runs   - 13  7 528 ✅  - 13  59 💤 ±0  0 ❌ ±0 

Results for commit 915a9a9. ± Comparison against base commit 3bf68cd.

♻️ This comment has been updated with latest results.

@Artur- Artur- mentioned this pull request Jun 7, 2024
Open
@mshabarov mshabarov requested a review from caalador June 10, 2024 05:43
caalador
caalador requested changes Jun 10, 2024
View reviewed changes
Copy link
Contributor

@caalador caalador left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems ok.
HistoryIT needs to be updated as the asdf pushState is not a history change event.

@tltv tltv changed the title chore: preserve navigated.current value fix: preserve navigated.current value Jun 10, 2024
@tltv tltv marked this pull request as ready for review June 10, 2024 07:40
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@Artur- Artur- merged commit ff79e5b into main Jun 10, 2024
25 of 34 checks passed
@Artur- Artur- deleted the fix/19525-preserve-navigated-state branch June 10, 2024 08:18
@vaadin-bot
Copy link
Collaborator

Hi @tltv and @Artur-, when i performed cherry-pick to this commit to 24.4, i have encountered the following issue. Can you take a look and pick it manually?
Error Message:
Error: Command failed: git cherry-pick ff79e5b
error: could not apply ff79e5b... fix: preserve navigated.current value (#19539)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

Artur- pushed a commit that referenced this pull request Jun 10, 2024
@tltv @Artur-
fix: preserve navigated.current value (#19539) (CP: 24.4)
b5f2e4c 
pushState does not trigger history change event.
Artur- added a commit that referenced this pull request Jun 10, 2024
@Artur-
fix: preserve navigated.current value (#19539) (CP: 24.4) (#19546)
ac4bb64 
pushState does not trigger history change event.
@leluna leluna mentioned this pull request Jun 20, 2024
Closed
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 24.5.0.alpha3 and is also targeting the upcoming stable 24.5.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caalador caalador caalador approved these changes

Assignees
No one assigned
Labels
need to pick manually 24.4 prerelease version for Vaadin 24.5.0 Released with Vaadin 24.5.0.alpha3 target/24.4 +0.0.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[PiT 24.4.0 RC1] business-app-starter-flow is broken with V24.4.0.rc1
4 participants
@tltv @vaadin-bot @caalador @Artur-