fix opaque lines in legend #40
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use mlines instead of drawing an extraneous line.
The extraneous line was not supposed to be visible, i.e., by setting alpha=0, but this resulted in invisible line style in the legend, which is obviously not what we want.
Note the pull request by @JanOpper also tried to fix this issue.
But that approach will make the extraneous line showing up in the plots.
Also I prefer the original PALLETE (this is the name of variable in the original codebase) instead of the uniformly drawn colors, shown here.
The old palette has colors more vivid to me.