-
Notifications
You must be signed in to change notification settings - Fork 221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding correlation distance metric in oneDAL primitives #3059
Open
richardnorth3
wants to merge
27
commits into
uxlfoundation:main
Choose a base branch
from
richardnorth3:dev/correlation-metric
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 3 commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
4fade17
Adding correlation distance metric
bb61721
Update metrics.hpp
richardnorth3 cd7c506
Update metrics.hpp with correlation_metric for GPU
richardnorth3 2039675
Add correlation distance test
richardnorth3 b4fd66a
Add supporting files for correlation distance
richardnorth3 22f03a8
Update metrics.hpp
richardnorth3 93a1c98
Update distance.hpp with correlation prototypes
richardnorth3 aec5d45
Merge branch 'dev/correlation-metric' of https://github.com/richardno…
richardnorth3 a53164d
Update metrics.hpp
richardnorth3 7ade161
Update correlation_distance_dpc.cpp
richardnorth3 c56b209
Update correlation_distance_dpc.cpp
richardnorth3 0b45447
Update correlation_distance_dpc.cpp
richardnorth3 9b09822
Update correlation_distance_dpc.cpp
richardnorth3 cc52792
Update bazel BUILD file with cov deps
richardnorth3 8232af4
Update bazel BUILD file
richardnorth3 8670a5a
Update bazel BUILD file
richardnorth3 7d88579
Update correlation_distance_dpc.cpp
richardnorth3 4740ad6
Update correlation_distance_dpc.cpp
richardnorth3 069a787
Update correlation_distance_dpc.cpp
richardnorth3 325e01b
Update cpp/oneapi/dal/backend/primitives/distance/correlation_distanc…
richardnorth3 01c4b72
Update cpp/oneapi/dal/backend/primitives/distance/correlation_distanc…
richardnorth3 f888e7a
Update correlation distance test and header
71609fc
Update correlation distance test
richardnorth3 8008137
Update correlation_distance_misc.hpp
richardnorth3 dbbbc3e
Update correlation_distance_misc_dpc.cpp
richardnorth3 a862a74
Update correlation distance test
68e8c4f
Update correlation_distance_misc_dpc.cpp
richardnorth3 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for writing this up @richardnorth3 ! https://docs.scipy.org/doc/scipy/reference/generated/scipy.spatial.distance.correlation.html should be a good reference for the means necessary. The mean doesn't need to be a single value, but a vector the size of a single sample with each being the mean value for each feature (i.e. for each row). This will then be a vector subtraction. Let me know if I am misunderstanding things about your implementation. Good progress.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey sorry about that, the definition is the mean of the 1d array, so my recommendations have been a little bit wrong.