Skip to content

Commit

Permalink
Revert "fixup add useConstFeatures parameter to oneapi interface"
Browse files Browse the repository at this point in the history
This reverts commit 6ba776f.
  • Loading branch information
ahuber21 committed Mar 24, 2023
1 parent b18e484 commit 02e8ac1
Show file tree
Hide file tree
Showing 5 changed files with 0 additions and 8 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,6 @@ static result_t call_daal_kernel(const context_cpu& ctx,
dal::detail::integral_cast<std::size_t>(desc.get_max_leaf_nodes());
daal_parameter.maxBins = dal::detail::integral_cast<std::size_t>(desc.get_max_bins());
daal_parameter.minBinSize = dal::detail::integral_cast<std::size_t>(desc.get_min_bin_size());
daal_parameter.useConstFeatures = desc.get_use_const_features();

daal_parameter.resultsToCompute = static_cast<std::uint64_t>(desc.get_error_metric_mode());

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,6 @@ static result_t call_daal_kernel(const context_cpu& ctx,
dal::detail::integral_cast<std::size_t>(desc.get_max_leaf_nodes());
daal_parameter.maxBins = dal::detail::integral_cast<std::size_t>(desc.get_max_bins());
daal_parameter.minBinSize = dal::detail::integral_cast<std::size_t>(desc.get_min_bin_size());
daal_parameter.useConstFeatures = desc.get_use_const_features();

daal_parameter.resultsToCompute = static_cast<std::uint64_t>(desc.get_error_metric_mode());

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,6 @@ void train_kernel_hist_impl<Float, Bin, Index, Task>::init_params(train_context_

ctx.bootstrap_ = desc.get_bootstrap();
ctx.max_tree_depth_ = desc.get_max_tree_depth();
ctx.use_const_features_ = desc.get_use_const_features();

ctx.splitter_mode_value_ = desc.get_splitter_mode();
ctx.seed_ = desc.get_seed();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,6 @@ struct train_context {
bool bootstrap_ = false;
bool use_private_mem_buf_ = true; // valuable for classification only
// for switching between private mem and other buffers(local, global) for storing class hist
bool use_const_features_ = false;

splitter_mode splitter_mode_value_;
std::uint64_t seed_;
Expand Down
4 changes: 0 additions & 4 deletions cpp/oneapi/dal/algo/decision_forest/common.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -229,11 +229,7 @@ class descriptor_base : public base {
std::int64_t get_min_bin_size() const;
bool get_memory_saving_mode() const;
bool get_bootstrap() const;
<<<<<<< HEAD
splitter_mode get_splitter_mode() const;
=======
bool get_use_const_features() const;
>>>>>>> fixup add useConstFeatures parameter to oneapi interface
error_metric_mode get_error_metric_mode() const;
variable_importance_mode get_variable_importance_mode() const;

Expand Down

0 comments on commit 02e8ac1

Please sign in to comment.