Remove CONUS/AK Search Constraint (cryocloud dev) #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed merge conflict between remote branches local vs cryocloud on updated main.py search
|
Go ahead and delete this test as well since we'll no longer check that polygons are in CONUS or Alaska coincident/tests/test_search.py Line 46 in f5aee55 |
|
Note the CI has caught an 'unused import' (https://github.com/uw-cryo/coincident/actions/runs/11388752896/job/31686459113?pr=10) since we've gotten rid of the code you can also remove that import at the top of the file |
scottyhq
requested changes
Oct 17, 2024
src/coincident/search/main.py
Outdated
| #AK = box(*(-179.99, 51.21, -129.63, 71.35)) | ||
| #if not aoi.within(CONUS) and not aoi.within(AK): | ||
| # message = "Requested search polygon not within Continental U.S. or Alaska" | ||
| # raise ValueError(message) |
There was a problem hiding this comment.
Go ahead and delete this rather than comment out
scottyhq
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as PR here except with a satisfactory Pixi dev build. Using CryoCloud remote branch rather than local