Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement -ls and -fls #435

Merged
merged 14 commits into from
Sep 5, 2024
Merged

Implement -ls and -fls #435

merged 14 commits into from
Sep 5, 2024

Conversation

hanbings
Copy link
Collaborator

@hanbings hanbings commented Aug 7, 2024

Closed #382

Copy link

codecov bot commented Aug 7, 2024

Codecov Report

Attention: Patch coverage is 67.70833% with 31 lines in your changes missing coverage. Please review.

Project coverage is 66.49%. Comparing base (f2e49d8) to head (457c681).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
src/find/matchers/ls.rs 70.73% 15 Missing and 9 partials ⚠️
src/find/matchers/mod.rs 12.50% 6 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #435      +/-   ##
==========================================
+ Coverage   66.46%   66.49%   +0.02%     
==========================================
  Files          35       36       +1     
  Lines        4270     4366      +96     
  Branches      959      979      +20     
==========================================
+ Hits         2838     2903      +65     
- Misses       1041     1062      +21     
- Partials      391      401      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Aug 7, 2024

Commit c4a65c3 has GNU testsuite comparison:

Run GNU findutils tests: GNU tests summary = TOTAL: 702 / PASS: 445 / FAIL: 254 / ERROR: 2
Run GNU findutils tests: Changes from main: PASS +0 / FAIL +0 / ERROR +0 / SKIP +0 
Run GNU findutils tests: Gnu tests No changes
Run BFS tests: Changes from main: PASS +2 / SKIP +0 / FAIL -2
Run BFS tests: BFS tests summary = TOTAL: 288 / PASS: 195 / SKIP: 1 / FAIL: 92

src/find/matchers/ls.rs Outdated Show resolved Hide resolved
Copy link

Commit bf16e63 has GNU testsuite comparison:

Run GNU findutils tests: GNU tests summary = TOTAL: 698 / PASS: 449 / FAIL: 246 / ERROR: 2
Run GNU findutils tests: Changes from main: PASS +0 / FAIL +0 / ERROR +0 / SKIP +0 
Run GNU findutils tests: Gnu tests No changes
Run BFS tests: Changes from main: PASS +2 / SKIP +0 / FAIL -2
Run BFS tests: BFS tests summary = TOTAL: 288 / PASS: 198 / SKIP: 1 / FAIL: 89

Copy link

Commit a672f35 has GNU testsuite comparison:

Run GNU findutils tests: GNU tests summary = TOTAL: 698 / PASS: 449 / FAIL: 246 / ERROR: 2
Run GNU findutils tests: Changes from main: PASS +0 / FAIL +0 / ERROR +0 / SKIP +0 
Run GNU findutils tests: Gnu tests No changes
Run BFS tests: Changes from main: PASS +2 / SKIP +0 / FAIL -2
Run BFS tests: BFS tests summary = TOTAL: 288 / PASS: 198 / SKIP: 1 / FAIL: 89

Copy link

Commit e3562de has GNU testsuite comparison:

Run GNU findutils tests: GNU tests summary = TOTAL: 698 / PASS: 449 / FAIL: 246 / ERROR: 2
Run GNU findutils tests: Changes from main: PASS +0 / FAIL +0 / ERROR +0 / SKIP +0 
Run GNU findutils tests: Gnu tests No changes
Run BFS tests: Changes from main: PASS +2 / SKIP +0 / FAIL -2
Run BFS tests: BFS tests summary = TOTAL: 288 / PASS: 198 / SKIP: 1 / FAIL: 89

Copy link

Commit 1764055 has GNU testsuite comparison:

Run BFS tests: Changes from main: PASS +2 / SKIP +0 / FAIL -2
Run BFS tests: BFS tests summary = TOTAL: 288 / PASS: 198 / SKIP: 1 / FAIL: 89
Run GNU findutils tests: GNU tests summary = TOTAL: 698 / PASS: 449 / FAIL: 246 / ERROR: 2
Run GNU findutils tests: Changes from main: PASS +0 / FAIL +0 / ERROR +0 / SKIP +0 
Run GNU findutils tests: Gnu tests No changes

Copy link

Commit 5a32387 has GNU testsuite comparison:

Run GNU findutils tests: GNU tests summary = TOTAL: 698 / PASS: 449 / FAIL: 246 / ERROR: 2
Run GNU findutils tests: Changes from main: PASS +0 / FAIL +0 / ERROR +0 / SKIP +0 
Run GNU findutils tests: Gnu tests No changes
Run BFS tests: Changes from main: PASS +2 / SKIP +0 / FAIL -2
Run BFS tests: BFS tests summary = TOTAL: 288 / PASS: 198 / SKIP: 1 / FAIL: 89

Copy link

Commit aeedbfc has GNU testsuite comparison:

Run GNU findutils tests: GNU tests summary = TOTAL: 698 / PASS: 449 / FAIL: 246 / ERROR: 2
Run GNU findutils tests: Changes from main: PASS +0 / FAIL +0 / ERROR +0 / SKIP +0 
Run GNU findutils tests: Gnu tests No changes
Run BFS tests: Changes from main: PASS +2 / SKIP +0 / FAIL -2
Run BFS tests: BFS tests summary = TOTAL: 288 / PASS: 198 / SKIP: 1 / FAIL: 89

@sylvestre
Copy link
Contributor

needs rebasing

Copy link

Commit d132e48 has GNU testsuite comparison:

Run BFS tests: Congrats! The bfs test common/L_ls is now passing!
Run BFS tests: Congrats! The bfs test common/ls is now passing!
Run BFS tests: Congrats! The bfs test gnu/fls is now passing!
Run BFS tests: Changes from main: PASS +3 / SKIP +0 / FAIL -3
Run BFS tests: BFS tests summary = TOTAL: 317 / PASS: 244 / SKIP: 6 / FAIL: 67
Run GNU findutils tests: GNU tests summary = TOTAL: 659 / PASS: 477 / FAIL: 179 / ERROR: 2
Run GNU findutils tests: Changes from main: PASS +0 / FAIL +0 / ERROR +0 / SKIP +0 
Run GNU findutils tests: Gnu tests No changes

Copy link

Commit 96e5740 has GNU testsuite comparison:

Run GNU findutils tests: GNU tests summary = TOTAL: 659 / PASS: 477 / FAIL: 179 / ERROR: 2
Run GNU findutils tests: Changes from main: PASS +0 / FAIL +0 / ERROR +0 / SKIP +0 
Run GNU findutils tests: Gnu tests No changes
Run BFS tests: Congrats! The bfs test common/L_ls is now passing!
Run BFS tests: Congrats! The bfs test common/ls is now passing!
Run BFS tests: Congrats! The bfs test gnu/fls is now passing!
Run BFS tests: Changes from main: PASS +3 / SKIP +0 / FAIL -3
Run BFS tests: BFS tests summary = TOTAL: 317 / PASS: 244 / SKIP: 6 / FAIL: 67

Copy link

Commit 457c681 has GNU testsuite comparison:

Run BFS tests: Congrats! The bfs test common/L_ls is now passing!
Run BFS tests: Congrats! The bfs test common/ls is now passing!
Run BFS tests: Congrats! The bfs test gnu/fls is now passing!
Run BFS tests: Changes from main: PASS +3 / SKIP +0 / FAIL -3
Run BFS tests: BFS tests summary = TOTAL: 317 / PASS: 244 / SKIP: 6 / FAIL: 67
Run GNU findutils tests: GNU tests summary = TOTAL: 659 / PASS: 477 / FAIL: 179 / ERROR: 2
Run GNU findutils tests: Changes from main: PASS +0 / FAIL +0 / ERROR +0 / SKIP +0 
Run GNU findutils tests: Gnu tests No changes

@sylvestre sylvestre merged commit f9d74ad into uutils:main Sep 5, 2024
19 checks passed
@hanbings hanbings deleted the implement-382 branch September 8, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement -ls and -fls
3 participants