Implement `-daystart` #413

hanbings · 2024-07-06T05:26:06Z

Closes #372

codecov · 2024-07-06T05:28:35Z

Codecov Report

Attention: Patch coverage is 94.59459% with 2 lines in your changes missing coverage. Please review.

Project coverage is 65.98%. Comparing base (4807264) to head (a68048b).

Files	Patch %	Lines
src/find/matchers/time.rs	90.90%	0 Missing and 2 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #413      +/-   ##
==========================================
+ Coverage   65.86%   65.98%   +0.12%     
==========================================
  Files          34       34              
  Lines        3978     4004      +26     
  Branches      909      912       +3     
==========================================
+ Hits         2620     2642      +22     
+ Misses        999      996       -3     
- Partials      359      366       +7

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

github-actions · 2024-07-06T05:30:07Z

Commit a95bf69 has GNU testsuite comparison:

Run GNU findutils tests: GNU tests summary = TOTAL: 702 / PASS: 445 / FAIL: 254 / ERROR: 2
Run GNU findutils tests: Changes from main: PASS +0 / FAIL +0 / ERROR +0 / SKIP +0 
Run GNU findutils tests: Gnu tests No changes
Run BFS tests: Changes from main: PASS +2 / SKIP +0 / FAIL -2
Run BFS tests: BFS tests summary = TOTAL: 288 / PASS: 192 / SKIP: 1 / FAIL: 95

sylvestre · 2024-07-06T07:02:53Z

src/find/matchers/time.rs

 }

 impl Matcher for FileAgeRangeMatcher {
    fn matches(&self, file_info: &DirEntry, matcher_io: &mut MatcherIO) -> bool {
-        match self.matches_impl(file_info, matcher_io.now()) {
+        let time = if self.today_start {


maybe move this into a function as you are duplicating it?

Thanks, it would be better to wrap it in a function. Changed in the latest commit.

github-actions · 2024-07-06T11:55:28Z

Commit d5af780 has GNU testsuite comparison:

Run GNU findutils tests: GNU tests summary = TOTAL: 702 / PASS: 445 / FAIL: 254 / ERROR: 2
Run GNU findutils tests: Changes from main: PASS +0 / FAIL +0 / ERROR +0 / SKIP +0 
Run GNU findutils tests: Gnu tests No changes
Run BFS tests: Changes from main: PASS +2 / SKIP +0 / FAIL -2
Run BFS tests: BFS tests summary = TOTAL: 288 / PASS: 192 / SKIP: 1 / FAIL: 95

github-actions · 2024-07-09T21:57:47Z

Commit 0649b10 has GNU testsuite comparison:

Run BFS tests: Changes from main: PASS +2 / SKIP +0 / FAIL -2
Run BFS tests: BFS tests summary = TOTAL: 288 / PASS: 193 / SKIP: 1 / FAIL: 94
Run GNU findutils tests: GNU tests summary = TOTAL: 702 / PASS: 445 / FAIL: 254 / ERROR: 2
Run GNU findutils tests: Changes from main: PASS +0 / FAIL +0 / ERROR +0 / SKIP +0 
Run GNU findutils tests: Gnu tests No changes

github-actions · 2024-07-09T22:06:34Z

Commit 30ecf22 has GNU testsuite comparison:

Run BFS tests: Changes from main: PASS +2 / SKIP +0 / FAIL -2
Run BFS tests: BFS tests summary = TOTAL: 288 / PASS: 193 / SKIP: 1 / FAIL: 94
Run GNU findutils tests: GNU tests summary = TOTAL: 702 / PASS: 445 / FAIL: 254 / ERROR: 2
Run GNU findutils tests: Changes from main: PASS +0 / FAIL +0 / ERROR +0 / SKIP +0 
Run GNU findutils tests: Gnu tests No changes

sylvestre · 2024-07-10T08:34:23Z

Looks like i broke the rebase, sorry :(
could you please fix it ? thanks :)

github-actions · 2024-07-11T12:12:42Z

Commit 81cc4d7 has GNU testsuite comparison:

Run BFS tests: Changes from main: PASS +2 / SKIP +0 / FAIL -2
Run BFS tests: BFS tests summary = TOTAL: 288 / PASS: 193 / SKIP: 1 / FAIL: 94
Run GNU findutils tests: GNU tests summary = TOTAL: 702 / PASS: 445 / FAIL: 254 / ERROR: 2
Run GNU findutils tests: Changes from main: PASS +0 / FAIL +0 / ERROR +0 / SKIP +0 
Run GNU findutils tests: Gnu tests No changes

github-actions · 2024-07-11T17:56:00Z

Commit cb90f29 has GNU testsuite comparison:

Run BFS tests: Changes from main: PASS +2 / SKIP +0 / FAIL -2
Run BFS tests: BFS tests summary = TOTAL: 288 / PASS: 193 / SKIP: 1 / FAIL: 94
Run GNU findutils tests: GNU tests summary = TOTAL: 702 / PASS: 445 / FAIL: 254 / ERROR: 2
Run GNU findutils tests: Changes from main: PASS +0 / FAIL +0 / ERROR +0 / SKIP +0 
Run GNU findutils tests: Gnu tests No changes

github-actions · 2024-07-11T20:03:53Z

Commit bfacdf6 has GNU testsuite comparison:

Run BFS tests: Changes from main: PASS +2 / SKIP +0 / FAIL -2
Run BFS tests: BFS tests summary = TOTAL: 288 / PASS: 193 / SKIP: 1 / FAIL: 94
Run GNU findutils tests: GNU tests summary = TOTAL: 702 / PASS: 445 / FAIL: 254 / ERROR: 2
Run GNU findutils tests: Changes from main: PASS +0 / FAIL +0 / ERROR +0 / SKIP +0 
Run GNU findutils tests: Gnu tests No changes

github-actions · 2024-07-11T20:32:21Z

Commit 85b8999 has GNU testsuite comparison:

Run GNU findutils tests: GNU tests summary = TOTAL: 702 / PASS: 445 / FAIL: 254 / ERROR: 2
Run GNU findutils tests: Changes from main: PASS +0 / FAIL +0 / ERROR +0 / SKIP +0 
Run GNU findutils tests: Gnu tests No changes
Run BFS tests: Changes from main: PASS +2 / SKIP +0 / FAIL -2
Run BFS tests: BFS tests summary = TOTAL: 288 / PASS: 193 / SKIP: 1 / FAIL: 94

github-actions · 2024-07-16T13:46:52Z

Commit f978708 has GNU testsuite comparison:

Run GNU findutils tests: GNU tests summary = TOTAL: 702 / PASS: 445 / FAIL: 254 / ERROR: 2
Run GNU findutils tests: Changes from main: PASS +0 / FAIL +0 / ERROR +0 / SKIP +0 
Run GNU findutils tests: Gnu tests No changes
Run BFS tests: Changes from main: PASS +2 / SKIP +0 / FAIL -2
Run BFS tests: BFS tests summary = TOTAL: 288 / PASS: 193 / SKIP: 1 / FAIL: 94

github-actions · 2024-07-18T20:11:50Z

Commit 4cad380 has GNU testsuite comparison:

Run GNU findutils tests: GNU tests summary = TOTAL: 702 / PASS: 445 / FAIL: 254 / ERROR: 2
Run GNU findutils tests: Changes from main: PASS +0 / FAIL +0 / ERROR +0 / SKIP +0 
Run GNU findutils tests: Gnu tests No changes
Run BFS tests: Changes from main: PASS +2 / SKIP +0 / FAIL -2
Run BFS tests: BFS tests summary = TOTAL: 288 / PASS: 193 / SKIP: 1 / FAIL: 94

github-actions · 2024-07-18T20:25:07Z

Commit a68048b has GNU testsuite comparison:

Run BFS tests: Changes from main: PASS +2 / SKIP +0 / FAIL -2
Run BFS tests: BFS tests summary = TOTAL: 288 / PASS: 193 / SKIP: 1 / FAIL: 94
Run GNU findutils tests: GNU tests summary = TOTAL: 702 / PASS: 445 / FAIL: 254 / ERROR: 2
Run GNU findutils tests: Changes from main: PASS +0 / FAIL +0 / ERROR +0 / SKIP +0 
Run GNU findutils tests: Gnu tests No changes

sylvestre · 2024-07-21T14:06:21Z

thanks :)

hanbings added 4 commits July 5, 2024 23:12

Try handle -daystart.

418c569

Added -daystart checker in time.rs.

ff98cea

Fixed errors caused by positive and negative time offsets.

0b16937

Added tests.

a95bf69

sylvestre reviewed Jul 6, 2024

View reviewed changes

Encapsulates the time acquisition function used to process -daystart.

d5af780

Merge branch 'main' into implement-372

0649b10

fix bad merge

30ecf22

Resolve conflicts.

81cc4d7

Fix tests code.

cb90f29

Merge branch 'main' into implement-372

bfacdf6

Typo test name.

85b8999

Merge branch 'main' into implement-372

f978708

Merge branch 'main' into implement-372

4cad380

Fix tests.

a68048b

hanbings requested a review from sylvestre July 18, 2024 20:25

sylvestre merged commit 1b9904e into uutils:main Jul 21, 2024
19 checks passed

BrewTestBot mentioned this pull request Sep 8, 2024

uutils-findutils 0.7.0 Homebrew/homebrew-core#183925

Merged

hanbings deleted the implement-372 branch September 18, 2024 09:42

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement `-daystart` #413

Implement `-daystart` #413

hanbings commented Jul 6, 2024

codecov bot commented Jul 6, 2024 •

edited

Loading

github-actions bot commented Jul 6, 2024

sylvestre Jul 6, 2024

hanbings Jul 6, 2024

github-actions bot commented Jul 6, 2024

github-actions bot commented Jul 9, 2024

github-actions bot commented Jul 9, 2024

sylvestre commented Jul 10, 2024

github-actions bot commented Jul 11, 2024

github-actions bot commented Jul 11, 2024

github-actions bot commented Jul 11, 2024

github-actions bot commented Jul 11, 2024

github-actions bot commented Jul 16, 2024

github-actions bot commented Jul 18, 2024

github-actions bot commented Jul 18, 2024

sylvestre commented Jul 21, 2024

Implement -daystart #413

Implement -daystart #413

Conversation

hanbings commented Jul 6, 2024

codecov bot commented Jul 6, 2024 • edited Loading

Codecov Report

github-actions bot commented Jul 6, 2024

sylvestre Jul 6, 2024

Choose a reason for hiding this comment

hanbings Jul 6, 2024

Choose a reason for hiding this comment

github-actions bot commented Jul 6, 2024

github-actions bot commented Jul 9, 2024

github-actions bot commented Jul 9, 2024

sylvestre commented Jul 10, 2024

github-actions bot commented Jul 11, 2024

github-actions bot commented Jul 11, 2024

github-actions bot commented Jul 11, 2024

github-actions bot commented Jul 11, 2024

github-actions bot commented Jul 16, 2024

github-actions bot commented Jul 18, 2024

github-actions bot commented Jul 18, 2024

sylvestre commented Jul 21, 2024

Implement `-daystart` #413

Implement `-daystart` #413

codecov bot commented Jul 6, 2024 •

edited

Loading