-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide GNU test comparison comments for PRs in Github Actions. #400
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #400 +/- ##
=======================================
Coverage 60.48% 60.48%
=======================================
Files 32 32
Lines 4069 4069
Branches 895 895
=======================================
Hits 2461 2461
Misses 1254 1254
Partials 354 354 ☔ View full report in Codecov by Sentry. |
nice ! |
Testing is hard, don't hesitate if you need to land it to test it further |
It seems that the compatibility information in and... I'm sorry for spending so much time testing. |
@tertsdiepraam do you remember if it can be tested inside a PR or it needs to be merged first ? |
I think it had to be merged... |
Also, I split it into 2 workflows on purpose, so that the workflow that posts the comments could have more permissions but the other workflow could be run from the PR. We should probably do the same here. See also some of the discussions and stuff around this feature in coreutils: uutils/coreutils#4010 |
I'm separating the code for sending PR comments into a new CI file, but Github Actions only runs the CI file that exists in the default branch. I'm not sure the code will work, can we merge this PR first and then fix the code issues? |
sure, i guess it isn't a draft anymore then ? |
done |
it is marked as skipped ?! https://github.com/uutils/findutils/actions/workflows/comment.yml |
yeah, I feel weird about that. I'll fix it in my fork. Thanks. |
don't hesitate to copy what is done in the coreutils :) |
link: #360
Add the PR comment code to
compat.yml
.But I don't have a good way to test this code yet, so I'm setting it to
Daft
for now.