Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(rgbpp-sdk/ckb): Add feeRate to calculateTransactionFee #55

Merged
merged 1 commit into from
Mar 26, 2024
Merged

refactor(rgbpp-sdk/ckb): Add feeRate to calculateTransactionFee #55

merged 1 commit into from
Mar 26, 2024
+10 −16

Conversation

duanyytop
Copy link
Collaborator

Main Changes

  • Add feeRate to the calculateTransactionFee function
  • Update the default feeRate from 1100 to 1000
  • Update the calculateTransactionFee tests

Reference

#44

@Flouse Flouse linked an issue Mar 26, 2024 that may be closed by this pull request
Support feeRate arg in fn calculateTransactionFee #44
Closed
@duanyytop duanyytop merged commit e047053 into main Mar 26, 2024
1 check passed
@duanyytop duanyytop deleted the refactor/ckb-tx-fee-rate branch March 26, 2024 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Flouse Flouse Flouse approved these changes

@ShookLyngs ShookLyngs ShookLyngs approved these changes

@ahonn ahonn Awaiting requested review from ahonn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support feeRate arg in fn calculateTransactionFee
3 participants
@duanyytop @Flouse @ShookLyngs