Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rgbpp-btc): P2TR basic support #20

Merged
merged 4 commits into from
Mar 13, 2024
Merged

feat(rgbpp-btc): P2TR basic support #20

merged 4 commits into from
Mar 13, 2024

Conversation

ShookLyngs
Copy link
Collaborator

@ShookLyngs ShookLyngs commented Mar 11, 2024

Changes

  1. Add basic support of P2TR
    • Adds support of specifying a P2TR address as the from adderss in the sendBtc() API
    • Adds a test to transfer from P2TR address, and sign with a tweaked signer
  2. Some refactors on variable names/positions

Reviewers

@Flouse @Dawn-githup @duanyytop

@ShookLyngs ShookLyngs requested a review from Flouse March 11, 2024 10:25
@ShookLyngs ShookLyngs self-assigned this Mar 11, 2024
@ShookLyngs ShookLyngs changed the title feat(rgbpp-btc): P2TR basic support as from address feat(rgbpp-btc): P2TR basic support Mar 11, 2024
@ShookLyngs ShookLyngs requested a review from duanyytop March 12, 2024 09:03
@duanyytop
Copy link
Collaborator

CI failed

@ShookLyngs
Copy link
Collaborator Author

CI failed

Ran out of utxos... thanks to @Dawn-githup for the donation.

@Flouse Flouse merged commit 7bda5a1 into main Mar 13, 2024
1 check passed
@duanyytop duanyytop deleted the feat/p2tr-address branch March 14, 2024 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants