Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(btc): add notes to TxBuilder.payFee() related functions #176

Merged
merged 1 commit into from
May 22, 2024
Merged

refactor(btc): add notes to TxBuilder.payFee() related functions #176

merged 1 commit into from
May 22, 2024

Conversation

ShookLyngs
Copy link
Collaborator

@ShookLyngs ShookLyngs commented May 16, 2024 •
edited
Loading

Changes

  • Add notes/comments to better explain the inner logic of the TxBuilder.payFee() related functions

    The change doesn't include actual logic refactors, therefore no changeset was added

Related issues

@ShookLyngs ShookLyngs mentioned this pull request May 21, 2024
Open
@Flouse Flouse merged commit eee6d89 into develop May 22, 2024
1 check passed
@Flouse Flouse deleted the ref/notes-to-pay-fee branch May 22, 2024 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Flouse Flouse Flouse approved these changes

@duanyytop duanyytop Awaiting requested review from duanyytop

@ahonn ahonn Awaiting requested review from ahonn

@Dawn-githup Dawn-githup Awaiting requested review from Dawn-githup

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Detailed explanation on TxBuilder.payFee()
2 participants
@ShookLyngs @Flouse