Add Internal module #729
Merged
Add Internal module #729
+3,039
−2,935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CedNaru
force-pushed
the
improvement/internal-module
branch
from
9becd27 to
07630d3
Compare
CedNaru
force-pushed
the
improvement/internal-module
branch
from
d2165ea to
39cb769
Compare
chippmann
approved these changes
Nov 3, 2024
piiertho
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Phase 2 of splitting the current godot library into several modules.
This time, I added a new module that is meant to be used as an "implementation" dependency for the core layer. Many previously internal classes were made public and moved to that new module. It means that the core library will be able to freely use them, but they won't be visible to the users.
Some classes had to be slightly modified to take into account that change because they previously referenced each other but are now in separate modules, which means that the reference can only be in one direction. It's actually a good thing, as it helps improve the quality of our code by removing coupling between classes. On that matter, the important changes are between MemoryManager (now in the new module) and KtObject (still in core).