Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add function to parse and filter Docker tags by date #5

Merged
merged 6 commits into from
Jan 22, 2024

Conversation

sscscc
Copy link
Contributor

@sscscc sscscc commented Jan 22, 2024

No description provided.

@iBug
Copy link
Member

iBug commented Jan 22, 2024

要不要过一遍 shellcheck?

@taoky
Copy link
Member

taoky commented Jan 22, 2024

感觉用 grep 来处理 JSON 有点太丑了(原来一个还好,现在的话代码就有些太乱了)……可以试试改成 jq 实现吗?

@sscscc
Copy link
Contributor Author

sscscc commented Jan 22, 2024

改成jq实现了√

@taoky
Copy link
Member

taoky commented Jan 22, 2024

建议在 CI 配置里面加一步安装 jq,虽然 ubuntu-latest 默认装了。这个弄好我觉得就可以合并了。

@sscscc
Copy link
Contributor Author

sscscc commented Jan 22, 2024

shellcheck过了,CI配置里加一步安装jq了

common.sh Outdated Show resolved Hide resolved
common.sh Outdated Show resolved Hide resolved
common.sh Outdated Show resolved Hide resolved
@sscscc
Copy link
Contributor Author

sscscc commented Jan 22, 2024

搞定√

Copy link
Member

@taoky taoky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(我相信这三个小地方是最后的修改了)

common.sh Outdated Show resolved Hide resolved
common.sh Show resolved Hide resolved
common.sh Outdated Show resolved Hide resolved
@taoky taoky merged commit 7e9fc75 into ustclug:master Jan 22, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants