updates for 24.2 #1392
Merged
updates for 24.2 #1392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bgruening
commented
Jan 27, 2025
| # Mappings are written to the table "gxitproxy" within the database. | ||
| # This value cannot match ``database_connection`` nor | ||
| # ``install_database_connection``. | ||
| #interactivetoolsproxy_map: null |
There was a problem hiding this comment.
That's ok, keep it as it is. After Galaxy has been updated I can go through the guide and merge the migration PR that I prepared, it will take care of changing this line.
bgruening
commented
Jan 27, 2025
| @@ -2573,6 +2587,13 @@ base_app_main: &BASE_APP_MAIN | |||
| # as threshold (above threshold: regular select fields will be used) | |||
| #select_type_workflow_threshold: -1 | |||
|
|
|||
| # API key for OpenAI (https://openai.com/) to enable the wizard (or | |||
| # more?) | |||
| #openai_api_key: null | |||
There was a problem hiding this comment.
ToDo Bjoern, would be nice to put in here a Key.
bgruening
commented
Jan 27, 2025
| @@ -13,7 +13,7 @@ built-in type, which could be any of the following types: int; long; float; str; | |||
| Note that the values of these attributes are case-sensitive. | |||
| --> | |||
| <OIDC> | |||
| <Setter Property="VERIFY_SSL" Value="True" Type="bool"/> | |||
| <Setter Property="VERIFY_SSL" Value="False" Type="bool"/> | |||
There was a problem hiding this comment.
@kysrpex does this look correct to you?
There was a problem hiding this comment.
No, this does not look correct at all. Let's set it back to True.
Suggested change
| <Setter Property="VERIFY_SSL" Value="False" Type="bool"/> | |
| <Setter Property="VERIFY_SSL" Value="True" Type="bool"/> |
If set to False, Custos auth won't verify ssl certificates (see for example custos_authnz.py#L393, custos_authnz.py#L483, custos_authnz.py#L483, custos_authnz.py#L169). PSA auth is not affected, but just by mistake (the option is never honored).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.