Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Braker3 #1091

Merged
merged 4 commits into from
Jan 31, 2024
Merged

Update Braker3 #1091

merged 4 commits into from
Jan 31, 2024

Conversation

rlibouba
Copy link
Contributor

Hello,
The Braker3 tool has been updated to version 3.0.7.
I opened this PR to update the toolshed.
Have a nice day!

@bgruening
Copy link
Member

Thanks for taking care of this. Should we maybe also support older version? I guess when we merge this, older versions will not work anymore?

@sanjaysrikakulam
Copy link
Member

sanjaysrikakulam commented Jan 31, 2024

The change in this PR will prevent this tool's old versions from getting scheduled.

Suppose you want to include the new version to get scheduled using a new container or parameters and conditions in addition to the old version. In that case, you can add a conditional like here to update/set the tools container and parameters.

@sanjaysrikakulam
Copy link
Member

Also, please update your branch; it seems outdated.

@rlibouba rlibouba reopened this Jan 31, 2024
@rlibouba
Copy link
Contributor Author

I feel stupid. I closed the PR in an attempt to update my branch and resolve conflicts. Sorry about that.

Thanks @sanjaysrikakulam for the feedback.
Thanks Eva for your help.

@bgruening
Copy link
Member

Thanks a lot, @rlibouba.

Nothing to feel stupid about. Next time we meet I will tell you my great git stories :)

@bgruening bgruening merged commit d7be20a into usegalaxy-eu:master Jan 31, 2024
4 checks passed
scheduling:
require:
- singularity
singularity_enabled: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the +galaxy suffixes are needed for the tool versions here, right?
Looks like braker3 is not working at EMBO training

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sanjaysrikakulam added a commit to sanjaysrikakulam/usegalaxy-eu_infrastructure-playbook that referenced this pull request Feb 2, 2024
sanjaysrikakulam added a commit to sanjaysrikakulam/usegalaxy-eu_infrastructure-playbook that referenced this pull request Feb 2, 2024
@sanjaysrikakulam sanjaysrikakulam mentioned this pull request Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants