-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Braker3 #1091
Update Braker3 #1091
Conversation
Thanks for taking care of this. Should we maybe also support older version? I guess when we merge this, older versions will not work anymore? |
The change in this PR will prevent this tool's old versions from getting scheduled. Suppose you want to include the new version to get scheduled using a new container or parameters and conditions in addition to the old version. In that case, you can add a conditional like here to update/set the tools container and parameters. |
Also, please update your branch; it seems outdated. |
328663f
to
1f89b32
Compare
I feel stupid. I closed the PR in an attempt to update my branch and resolve conflicts. Sorry about that. Thanks @sanjaysrikakulam for the feedback. |
Thanks a lot, @rlibouba. Nothing to feel stupid about. Next time we meet I will tell you my great git stories :) |
scheduling: | ||
require: | ||
- singularity | ||
singularity_enabled: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the +galaxy suffixes are needed for the tool versions here, right?
Looks like braker3 is not working at EMBO training
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It got mistakenly removed in the PR usegalaxy-eu#1091
Hello,
The Braker3 tool has been updated to version 3.0.7.
I opened this PR to update the toolshed.
Have a nice day!