Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add copernicus notebook #1050

Merged
merged 1 commit into from
Dec 12, 2023
Merged

add copernicus notebook #1050

merged 1 commit into from
Dec 12, 2023

Conversation

bgruening
Copy link
Member

No description provided.

@bgruening
Copy link
Member Author

@Marie59 ping

@Marie59
Copy link
Contributor

Marie59 commented Dec 12, 2023

ooh right I always forget

@bgruening
Copy link
Member Author

If this gets merged, the next day the tool should be working.

@Marie59
Copy link
Contributor

Marie59 commented Dec 12, 2023

This is new right ?

@bgruening
Copy link
Member Author

TPV is new'ish yes. And its a bit redundant, we could be smarter here, but for the time being, we need to do that.

@kysrpex we could use wildcards here for all interactive_tools_* ?

@Marie59
Copy link
Contributor

Marie59 commented Dec 12, 2023

I don't understand the error. Why is it searching for a login ?

@bgruening
Copy link
Member Author

Its doing some live testing of the rules and ITs do require a Galaxy login I think.

Don't worry, admins told me that is ok :)

@bgruening bgruening merged commit 4a903b2 into master Dec 12, 2023
3 of 4 checks passed
@bgruening bgruening deleted the bgruening-patch-6 branch December 12, 2023 17:01
@kysrpex
Copy link
Contributor

kysrpex commented Dec 13, 2023

TPV is new'ish yes. And its a bit redundant, we could be smarter here, but for the time being, we need to do that.

@kysrpex we could use wildcards here for all interactive_tools_* ?

Yes, for example u can add an entry interactive_tool_*: under line 18 and make it inherit from interactive_tool. Alternatively just rename interactive_tool.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants