Target pallet-revive instead of pallet-contracts
#2356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmichi
force-pushed
the
cmichi-remove-wasm-default-to-revive
branch
6 times, most recently
from
b8ec94c to
247fec5
Compare
Remove `LimitParamsV1` + `pallet-contracts` Use RISC-V target in CI Use latest `polkadot-sdk` `master` Use `H256` instead of `E::Hash` Remove generic from `ToAddr` and `FromAddr` Remove support for `no_implicit_prelude` Remove `Determinism`
This reverts commit 86411fa69b220972eb2194013bd6d7c614fabefb.
cmichi
force-pushed
the
cmichi-remove-wasm-default-to-revive
branch
from
247fec5 to
c13398b
Compare
This reverts commit ae62747.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves ink! from WebAssembly on
pallet-contractsto PolkaVM onpallet-revive. With this PR we are moving towards the next major release of ink!, version 6, which will no longer support Wasm/pallet-contracts.Compatibility
The PR uses the version of
polkadot-sdk(so alsopallet-revive) from commit645878a27115db52e5d63115699b4bbb89034067.It works with
cargo-contractfrom this branch and this version ofsubstrate-contracts-node:Two important notes:
cargo +nightly contract). Otherwise you'll get an ICE with the errorunknown RISC-V ABI name.cargo-contract, you have to submit the extrinsicrevive::mapAccount()in polkadot-js first. So if you e.g. use the arg--suri //Aliceyou have to callmapAccount()from Alice in polkadot-js first. This is becausepallet-reviverequires a mapped account.Next Steps
The PR doesn't leave the code in a perfect state, there are still a lot of todo's in the code. I've disabled some individual tests for now, as they require work in external dependencies first. I'm merging the PR to have a base to work off and synchronize work with others.
The PR contains a lot of breaking changes that will be documented in more verbatim form in the release notes and this migration guide.