Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate Path Bug Fix #529

Merged
merged 1 commit into from
Dec 27, 2023

Conversation

payneBrandon
Copy link
Collaborator

@payneBrandon payneBrandon commented Dec 27, 2023

Moving JsonProperty declaration to getters to avoid duplicate fetch in serialization/deserialization scenarios

PR Details

Description

This PR moves the "@JsonProperty" declaration in the NodeSetXY and Nodes classes to their respective getters rather than the private property declaration. For some reason, having those on the private property exposed that private property when serializing/deserializing and as a result both the private property and the public getter method were called - causing paths to come out as duplicated.

Related Issue

Motivation and Context

Solves problem described in description

How Has This Been Tested?

Tested locally, and in WYDOT test environment

Types of changes

  • Defect fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that cause existing functionality to change)

Checklist:

  • I have added any new packages to the sonar-scanner.properties file
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
    ODE Contributing Guide
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link
Collaborator

@dmccoystephenson dmccoystephenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me!

This was tested in my local environment and in WYDOT's environment. Without the fix, we were getting duplicate NodeXY nodes and with the fix, we are no longer getting these duplicates.

With and without the fix, the same number of NodeLL nodes get generated, suggesting that this duplication problem was not affecting TIMs with offsets.

@payneBrandon payneBrandon marked this pull request as ready for review December 27, 2023 22:15
@dan-du-car dan-du-car merged commit 6a497f2 into usdot-jpo-ode:develop Dec 27, 2023
1 of 2 checks passed
@dmccoystephenson dmccoystephenson deleted the fix/duplicate-paths branch December 27, 2023 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants