Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ELS-CRU] Proform Details Page MVP #2000

Merged

Conversation

Rwolfe-Nava
Copy link
Collaborator

@Rwolfe-Nava Rwolfe-Nava commented Jan 21, 2025

Link to the ticket.

What does this change?

Adds several fields to the details view for reports created with the ELS-CRU proform with the ability to edit and save their information. (See the thread in the above ticket for more information)

Screenshots (for front-end PR):

Checklist:

Author

  • If this is a story, run locally and check to make sure all Acceptance Criteria are met. (If any criteria are unclear, ask about them.).
  • Check for, document, and establish a testing plan for any behavior that may vary across environments or is otherwise difficult to test.
  • Check for accessibility.
  • Tests pass.

Reviewer

  • If this is a story, run locally and check to make sure all Acceptance Criteria are met. (If any criteria are unclear, ask about them.).
  • Check for any behavior that may vary across environments or is difficult to test, and ensure that it is well-understood, documented, and that there is a testing plan in place.
  • Re-check for accessibility.
  • Tests pass.

Notes for reviewer:

See PR instructions doc for full pull request review instructions.

@Rwolfe-Nava Rwolfe-Nava changed the title [Heavily WIP Still] Add Additional Contacts and Fields to Details page - CRU Proform support [WIP] Add Additional Contacts and Fields to Details page - CRU Proform support Jan 22, 2025
@Rwolfe-Nava Rwolfe-Nava force-pushed the rw/add-eeoc-contact-person-and-email-to-cru-proform branch from 6d93a82 to 086e412 Compare January 23, 2025 17:15
@Rwolfe-Nava Rwolfe-Nava marked this pull request as ready for review January 24, 2025 01:18
@Rwolfe-Nava Rwolfe-Nava changed the title [WIP] Add Additional Contacts and Fields to Details page - CRU Proform support [ELS-CRU] Proform Details Page MVP Jan 24, 2025
@Rwolfe-Nava Rwolfe-Nava requested a review from okkays January 24, 2025 15:42
Copy link
Collaborator

@okkays okkays left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! nice work!

crt_portal/cts_forms/forms.py Outdated Show resolved Hide resolved
@Rwolfe-Nava Rwolfe-Nava merged commit 71e7451 into develop Jan 29, 2025
1 check passed
@Rwolfe-Nava Rwolfe-Nava deleted the rw/add-eeoc-contact-person-and-email-to-cru-proform branch January 29, 2025 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants