attempt to address #1 #2
Open
+111
−48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomasholderness
requested changes
Apr 26, 2017
| logger.error('Postgres connection error: ' + err); | ||
|
|
||
| logger.info('Enabling caching mode and attempting to reconnect at intervals'); | ||
| reports.enableCacheMode(); |
There was a problem hiding this comment.
reports object not available in this context, but we don't need caching because without database connection there is no incoming data.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have done this pull request against dev; github is not understanding how to do it against master because master has the same commit for the fix for #1 as pgreconnect branch, even though I later reverted it in master because it's not working. Ignore my other attempt 7a30815 to work around that github bug.